Sign in Register
Copied to clipboard

Flag this post as spam?

This post will be reported to the moderators as potential spam to be looked at


  • Asbjørn 82 posts 195 karma points c-trib
    Mar 03, 2015 @ 23:14
    Asbjørn
    0

    Some small issues in Umbraco 7

    Thanks for making this very useful package!

    I noted various issues with the icon picker in Umbraco 7 and I made a PR here: https://github.com/marcemarc/monosnow.umbraco.uCssClassNameDropdown/pull/2

    Specifically, this PR contains the following changes:

    • The first item is not shown. This happens because the cssRegex.test(cssText); call moves past the first result. I have added cssRegex.compile to reset the regex
    • I have reduced the minimum height and set the scrollbar to show only when needed
    • I have removed the select element, as it seemed to serve no purpose
    • I have added a check for when no excludeList is set - then it will just be an empty string instead of null
    Copy Link

  • This forum is in read-only mode while we transition to the new forum.

    You can continue this topic on the new forum by tapping the "Continue discussion" link below.

Please Sign in or register to post replies