Hi Hieu Nguyen Trung,

thank your for your report. Unfortunately it's impossible for us to give support to all packages and this packages is not one on our list to be tested.

It does sound weird though because we do not do much with the frontend of someone's website.

If you say: "it does not work as expected" could you give some more details? What did you expect? And what was the result? Some screenshots will probably be very usefull.

And if you can give me some more information about the Umbraco version + uMarketingSuite version you're using, then may be I can help you out.

Kindest regards,

Jeffrey

I can assist with HtmlMinifier issues, can you provide details about the issuse, is it backoffice or front?

Hi Jeffrey and Yakov,

Thank you so much for your response.

When I have HtmlMinifier + uMarketingSuite, the result is like this

which break the whole page apart.

I tried to remove uMarketingSuite only (keep all other dependencies of it), and HtmlMinifier works, the html is minified with no big gap as above.

The issue only happens on frontend.

I am using:

Umbraco 8.6.4
uMarketingSuite 1.3.0
HtmlMinifier 1.0.1
WebMarkupMin.Core 2.8.6
WebMarkupMin.AspNet.Common 2.8.8
WebMarkupMin.AspNet4.Common 2.8.1
WebMarkupMin.AspNet4.Mvc 2.8.1

Minifier should remove spaces html and also can shortage tags. What issues do you see on the front?

Look like stange tags inside a, can you show tag without minification?

can you add this key in app settings

add this key in web.config in appSettings section

 <add key="RemoveOptionalEndTags" value="true" />

can you explaing what issue do you experience?
can you removi HtmlMinifier dll from bin, is it worked correctly?

I'll try to reproduce it

or now I see what on clean installation of Umbraco and HtmlMinifier it is working correctly, after installation of uMarketingSuite it has some strange behavour in html. I'm continue inverstigation

looks like some html added when both plugin are installed

Hi Hieu Nguyen Trung & Yakov Lebski,

this is really strange, but thank you for the screenshots and the research!

@Yakov: Any clue how this could happen? Can you maybe elaborate on how the minifier works? Maybe this gives us a hint where this could come from?

Thanks!

Jeffrey

HtmMinifier just wrap WebMarkupMin,

when I try use

Clean Umbraco + with default starter kit + uMarketingSuite => works good Clean Umbraco + with default starter kit + HtmlMinifier =>works good

Clean Umbraco + with default starter kit +uMarketingSuite + HtmlMinifier =>stange html generated

Does uMarketingSuite modify html after generation by Razor?

Looks like WebMarkupMin also uses a filtered Stream concept to apply the minification. This stream wraps the HttpResponseBase.Filter stream and when it's closed at the end of a request will minify all content written to it.

We actually use the same principle but clearly these two don't work together properly when wrapping each other, seems like WebMarkupMin wraps our stream as their ActionFilter runs on ResultExecuted and we on ResultExecuting.

I reproduced the issue and tried some quick fixes in our code. I did get some working minified output together with uMarketingSuite content (we append some <script> tags for example) so that looks promising. I could get rid of the strange characters at least. It wasn't working 100% yet but I assume we can get this to work sometime in the near future.

Hi Hieu Nguyen Trung,

last week we've released uMarketingSuite 1.4 and this issue is fixed in this version.

Hopefully you can verify that as well!

Kindest regards,

Jeffrey

is working on a reply...