Hi Matt,

I do not have much experience with multi page Umbraco Forms and have not seen this before. Does this happen with any fields that are mandatory and left empty when trying to navigate between pages? What about when using the default Recaptcha that comes with Forms? Does it still occur when the Recaptcha is checked or only when it's left empty?

Regards, Daniël

Hi Daniel,

Thanks for the reply, it's not to do with mandatory fields. I stepped through the source.

In UmbracoEvents.cs there is:

UmbracoFormsController.FormValidate += RecaptchaValidate;

This adds the recaptcha check each time the form is validated, so when moving from one page to the next it fires. Then since the Recaptcha is on the 2nd page, the validation fails, and the navigation fails.

I wonder how Umbraco.Forms does this with their version of the Recaptcha?, as this does allow navigation between pages.

Probably need to update the code, so it only fires to validate if the page that is being validated contains a recaptcha control.

Looks like this can be done via the FormValidationEventArgs.

I had exactly the same problem with the reCAPTCHA validating on a multi-step form. Fortunately, the contourPage div sits within a form, which has a FormStep hidden field, the value of which is the current form step.

As all our forms (and I guess most others) have the reCAPTCHA right at the end of the form, it can safely be assumed (as in the code below) that the control is on the last step.

<input name="FormStep" type="hidden" value="0">

So, all you need to do is check to see if the current step is equal to the total number of steps, THEN do the reCAPTCHA validation, giving the following source change in UmbracoEvents.cs

private void FormValidate(object sender, FormValidationEventArgs e)
    {
        //check to see which step we are at on the form (the last step will always contain the ReCaptcha control)
        int loop1 = 0;
        int currentStep = 0;
        String[] arr1 = e.Context.Request.Form.AllKeys;
        for (loop1 = 0; loop1 < arr1.Length; loop1++)
        {
            if (arr1[loop1] == "FormStep")
            {
                currentStep = Convert.ToInt16(e.Context.Request.Form["FormStep"]) + 1;
                break;
            }
        }

        //only try to validate a ReCaptcha control if we are on the last step
        if (currentStep == e.Form.Pages.Count)
        {
            JToken jToken = null;
            JToken jToken1 = null;

            LogHelper.Info<UmbracoFormsEvents>("FormValidate with ReCaptcha Running...", new Func<object>[0]);
            List<Field> list = (
                from f in e.Form.AllFields
                where f.FieldType.Name.Contains("GoogleReCaptcha")
                select f).ToList<Field>();
            if (list.Any<Field>())
            {
                Field field = list.FirstOrDefault<Field>();
                HttpContext current = HttpContext.Current;
                string setting = Configuration.GetSetting("RecaptchaPrivateKey");
                if (setting != "")
                {
                    string item = current.Request["g-recaptcha-response"];
                    string str = string.Format("https://www.google.com/recaptcha/api/siteverify?secret={0}&response={1}", setting, item);
                    bool flag = false;
                    List<string> strs = new List<string>();
                    //required to force TLS1.2 as TLS1.1 is disabled on the server
                    ServicePointManager.SecurityProtocol = SecurityProtocolType.Tls12;
                    using (WebClient webClient = new WebClient())
                    {
                        JObject jObject = JObject.Parse(webClient.DownloadString(str));
                        if (jObject.TryGetValue("success", out jToken))
                        {
                            flag = Extensions.Value<bool>(jToken);
                        }
                        if (!jObject.TryGetValue("error-codes", out jToken1))
                        {
                            strs.Add("unknown-error");
                        }
                        else
                        {
                            JEnumerable<JToken> jEnumerable = jToken1.Children();
                            strs.AddRange(
                                from child in (IEnumerable<JToken>)jEnumerable
                                select Extensions.Value<string>(child));
                        }
                    }
                    if (!flag)
                    {
                        Controller controller = sender as Controller;
                        string str1 = ",";
                        foreach (string str2 in strs)
                        {
                            str1 = string.Concat(str1, ", ", str2);
                        }
                        str1 = str1.Replace(",,", "");
                        string str3 = string.Format("Recaptcha Verification Failed: {0}", str1);
                        if (field != null)
                        {
                            if (controller != null)
                            {
                                controller.ModelState.AddModelError(field.Id.ToString(), str3);
                            }
                        }
                    }
                }
                else
                {
                    LogHelper.Warn<UmbracoFormsEvents>("ERROR: ReCaptcha v.2 is missing the Secret Key - Please update the '/app_plugins/umbracoforms/umbracoforms.config' to include 'key=\"RecaptchaPrivateKey\"'", new Func<object>[0]);
                }
            }
        }
    }

You will notice one additional line which may come in handy. We disabled TLS1.1 on our server which stopped communication with the Google secure server, so I had to force the internet connection to use TLS1.2

Finally I agree with Matt Barlow, it is an awesome package and saved me so much time.

Thanks for your reply Rob, I'm sure your code will be of help. I'm sorry, this issue has not been a priority here as we have been busy with a million other things, but I see it's been far too long now since it was first reported. I will try my best to make some time for this next week to fix the Recaptcha on multi-page forms using the input provided here.

Hi Rob & Matt -- and others :-),

I just uploaded a new version (1.8) which incorporates Matt's fix for this issue. ValidateField indeed seems the way to go for this one, thanks for your input!

-- Daniël

Awesome Daniel. thanks. :)

is working on a reply...