Using V7 and the latest uMirror, it seems that properties that are null/missing in umbraco are always synced, even if the ignore property is checked. This results in needless updates. Technically, I guess, that's two bugs.
dotPeek leads me to a line similar to this in Synchronizer.cs:comparValues()
if (index.Element((XName) prop.UmbPropertyAlias) == null)
return false;
I've also noticed that when the umbraco log gets larger, the project node takes a really long time to load.
If the source were available, it would make debugging these errors much easier. I'd also be happy to contribute a tested patch.
The log tags read logs from the files system, so if they have a lot of files, it takes a really long time, we will change that with a different approach.
I haven't yet been able to reproduce the same issue with this code, but I'm still poking around. It may have been related to Umbraco leaving out whitespace xml nodes or some such thing. I'll post here if I find something.
In the meantime, I've done a git filter-branch on the repo to remove the packages folder and added it to the .gitignore. I've also converted the xcopy post build commands to msbuild tasks, so I could include the project directly in my website solution (the solution dir references are wrong in that case and the copy commands fail.)
You may want to consider force pushing my current head over top of yours to remove the packages folder before more commits get added to the repo.
I'd send a pull request, but I have no bloody idea what github will make of the forced update of master when it comes over to you, probably easier to do something like this on your end:
I didn't send a pull request since I did a force update of master to remove all history of the packages folder. You can either try the commands in my previous comment, or just run the same command I did and I'll fix up my version.
Always syncing null values from xml
Using V7 and the latest uMirror, it seems that properties that are null/missing in umbraco are always synced, even if the ignore property is checked. This results in needless updates. Technically, I guess, that's two bugs.
dotPeek leads me to a line similar to this in Synchronizer.cs:comparValues()
if (index.Element((XName) prop.UmbPropertyAlias) == null)
return false;
I've also noticed that when the umbraco log gets larger, the project node takes a really long time to load.
If the source were available, it would make debugging these errors much easier. I'd also be happy to contribute a tested patch.
Hi Matt,
Thanks you for your feedback! I have just pushed the project in a public repository https://github.com/Lecoati/umirror
The log tags read logs from the files system, so if they have a lot of files, it takes a really long time, we will change that with a different approach.
Quick reply, Antoine, thanks. I'll incorporate the source into my project and start looking at a fix shortly.
I haven't yet been able to reproduce the same issue with this code, but I'm still poking around. It may have been related to Umbraco leaving out whitespace xml nodes or some such thing. I'll post here if I find something.
In the meantime, I've done a git filter-branch on the repo to remove the packages folder and added it to the .gitignore. I've also converted the xcopy post build commands to msbuild tasks, so I could include the project directly in my website solution (the solution dir references are wrong in that case and the copy commands fail.)
You may want to consider force pushing my current head over top of yours to remove the packages folder before more commits get added to the repo.
https://github.com/mwoodruff/umirror
I'd send a pull request, but I have no bloody idea what github will make of the forced update of master when it comes over to you, probably easier to do something like this on your end:
git remote add umirror_matt [email protected]:mwoodruff/umirror.git
git fetch
git checkout master
git reset --hard umirror_matt/master
git push origin master -f
That is, if you are interested in the update. I'll keep trying to reproduce the issue I've had, maybe it's already been fixed.
Hi Matt, I can't see your pull request, have you already sent it? I will integrate those changes in the master
I didn't send a pull request since I did a force update of master to remove all history of the packages folder. You can either try the commands in my previous comment, or just run the same command I did and I'll fix up my version.
Here's what I did:
git filter-branch --index-filter "git rm -rf --cached --ignore-unmatch packages/" HEAD
git push origin master -f
If you do that, I can rebase my changes and send you a pull request.
is working on a reply...