Copied to clipboard

Flag this post as spam?

This post will be reported to the moderators as potential spam to be looked at


  • Robbie van den Hoven 36 posts 181 karma points
    Nov 23, 2018 @ 12:51
    Robbie van den Hoven
    0

    Hide search button when there are no search keys

    Hi,

    First of all, great package!

    Second, is it possible to hide the search button in the datatype if there are no search (api) keys populated.

  • David Sheiles 67 posts 337 karma points
    Nov 25, 2018 @ 22:26
    David Sheiles
    0

    Thanks Robbie, glad you like it!

    It should hide the search button automatically (And just show the single video load button) if you leave the API keys blank.

    Is this that not happening for you?

  • Robbie van den Hoven 36 posts 181 karma points
    Nov 26, 2018 @ 08:22
    Robbie van den Hoven
    0

    Hi David,

    No, the search button in still there even with no field filled.

    enter image description here enter image description here

    Because you indicate that the button should be hidden, I went to see the installation. I had installed it via Nuget. I noticed that if you download the package via ou.umbraco, you get 'Videolizer_2.1.3' while the text 'version 2.1.4' is mentioned.

  • David Sheiles 67 posts 337 karma points
    Nov 26, 2018 @ 11:29
    David Sheiles
    0

    Thanks Robbie, that search icon shouldn't be there. I checked on a couple of my sites running it today without an API key and they were fine.

    • Which version on Umbraco are you running?

    • Are you able to try creating an additional Videolizer Data Type and try switching it in the Document Type to see if the same occurs?

    I had a quick look today, but will have a better look into to reproducing the issue.

    As for the 2.1.3 / 2.1.4 issue, Videolizer had an issue with deployments on cloud which pushed it to V 2.1.4, however it didn't affect Videolizer.Core so its still sitting at 2.1.3 and will work with either version. Thats why the 2 Nuget packages are out of sync

  • David Sheiles 67 posts 337 karma points
    Nov 26, 2018 @ 12:36
    David Sheiles
    0

    Robbie, can you check each of the setting fields to make sure that there is no white-space in any of the boxes. I was able to reproduce the issue by adding a space character in the API fields.

    It seems older versions of Umbraco trim the white-space from the DocType settings whereas the new versions, leave the white-space there.

    I will update the plugin to trim off any white-space characters.

    Let me know if that works.

  • Robbie van den Hoven 36 posts 181 karma points
    Nov 27, 2018 @ 11:05
    Robbie van den Hoven
    1

    Hi David,

    I am running the latest version (7.12.4). I also reinstalled the package.

    I think I found when the 'bug' occurs. When I add (reuse) the pre installed datatype 'Videolizer' the search button is hidden.

    When I create a New data type and choose for 'Videolizer Video Picker' at the property editor field, the search button pops up.

  • David Sheiles 67 posts 337 karma points
    Nov 27, 2018 @ 11:31
    David Sheiles
    100

    Thanks for finding that Robbie! the API keys come through as null instead of and empty string.

    I've applied a fix and will be in the next release.

    For now as a workaround, you can put something in each setting, save, and then remove them all and then re-save. This sets the keys as an empty string and it appears to hid the search icon.

Please Sign in or register to post replies

Write your reply to:

Draft