Hey Kevin,

Orders (by default) are not created until a payment has been received and is generally done via the IPaymentResult.ApproveOrderCreation property.

In the Merchello.config there is a property that can be used to override this setting.

<!-- 
Overrides the Payment Method's IPaymentResponse ApproveOrderCreation indicating an order should always be created no matter
if the payment has been collected or not. 
-->
<setting alias="AlwaysApproveOrderCreation" value="false" /> 

Setting this to true will create the order whether or not it is paid or not.

The order status will be set to unfulfilled even if there is no order IF there are shippable items (until version 2.2 ... if I remember ... it would actually remain unfulfilled even if there were no shippable items, but that was updated and resolved).

Hi Rusty,

thanks for your reply.

I do have AlwaysApproveOrderCreation set to false which works as desired.

To make myself clearer:

1) I create an invoice - this works fine and no order is created owing to the flag above.

2) As a second step in my own code, I then pay the invoice like this

invoice.AuthorizeCapturePayment(cash.Key)

These two steps alone result in a paid fulfilled invoice.

However, when an invoice is paid, I want to do some custom logic. I do this by adding a step to the OrderPreparationOrderCreate task chain:

<taskChain alias="OrderPreparationOrderCreate">
        <tasks>
            <task type="Merchello.Core.Chains.OrderCreation.ConvertInvoiceItemsToOrderItemsTask, Merchello.Core" />
            <task type="MyNamespace.MyClass.OrderCreatedTask, MyAssembly" />
        </tasks>
    </taskChain>

And my code looks like:

namespace MyNamespace
{
    public class MyClass : OrderCreationAttemptChainTaskBase
    {
        public OrderCreatedTask(IInvoice invoice)
            : base(invoice)
        {
        }

        public override Attempt<IOrder> PerformTask(IOrder value)
        {
            if (!DoSomething())
            {
                order.OrderStatus.Key = Constants.DefaultKeys.OrderStatus.NotFulfilled;
            }
            return Attempt<IOrder>.Succeed(value);
        }
    }
}

If the call to DoSomething() fails (returns false) I want the invoice (and order) to be unfulfilled. But what happens is the order correctly shows under "Unfulfilled Orders" but has a "Fulfillment Status" of Fulfilled as in the image below.

What I want to achieve is to have an unpaid invoice (effectively cancelling the payment just entered) and for the order to be unfulfilled. I hope that makes more sense.

Thanks for your help.

To expand on this, the code above does not refund the invoice payments. I have added this to the code:

public override Attempt<IOrder> PerformTask(IOrder value)
{
    if (!DoSomething())
    {
        order.OrderStatus.Key = Constants.DefaultKeys.OrderStatus.NotFulfilled;
        var cashProvider = MerchelloContext.Current.Gateways.Payment.GetProviderByKey(
                        Constants.ProviderKeys.Payment.CashPaymentProviderKey);
        var cash = cashProvider?.PaymentMethods.FirstOrDefault();
        if (cash != null)
        {
            foreach (var p in invoice.Payments())
            {
                invoice.RefundPayment(p, cash.Key, p.Amount);
            }
        }
    }
    return Attempt<IOrder>.Succeed(value);
}

And now in the "Unfulfilled Orders" section I see an unpaid invoice as desired, but the fulfillment status is still displaying as fulfilled.

Thanks Rusty. The item in question is not shippable.

That would make sense. I am pretty sure it is just the label. All my other testing to date seems OK and the status guids in the database look OK.

I think I have got to the bottom of this now. I have changed this code

var orderService = MerchelloContext.Current.Services.OrderService;
order.OrderStatus.Key = Constants.DefaultKeys.OrderStatus.NotFulfilled;
orderService.Save(order);

to this code

var orderService = MerchelloContext.Current.Services.OrderService;
order.OrderStatus = orderService.GetOrderStatusByKey(Constants.DefaultKeys.OrderStatus.NotFulfilled);
orderService.Save(order);

and that seems to have solved it.

I think the original code changed the cached copy of the data, and changed it incorrectly (bad data integrity, order status key and order status name mismatch).

Once in cache, although the data in the database was correct, the bad integrity cached copy was being used. By flushing the cache the correctly saved data was read from the database causing the objects to be constructed correctly and so displayed in the back office correctly regardless which version of the code above is used.

No worries,

Whilst the caching issue should be investigated, the real issue is that I introduced bad data integrity by having an OrderStatus with a mismatching key and string name.

Perhaps this could be avoided by either:

1) When updating order.OrderStatus.Key have the object do a full refresh and cache update internally?

or

2) encapsulating my solution in my previous in a helper method like:

orderService.ChangeStatus(Constants.DefaultKeys.OrderStatus.NotFulfilled);

or

orderService.SetStatus(Constants.DefaultKeys.OrderStatus.NotFulfilled);

Just an idea...

is working on a reply...