I got 2 little issues with some hardcoded text (as seen in the screenshot).
My whole webshop is in Dutch, except these two labels. I just want them to show the name of the shipment (PostNL in this case) and for Tax I want it to show 6% and not Netherlands.
I found out that the shipment line is being set inside the merchello core
public static T AsLineItemOf<T>(this ITaxCalculationResult taxCalculationResult) where T : LineItemBase
{
var ctrValues = new object[]
{
EnumTypeFieldConverter.LineItemType.Tax.TypeKey,
taxCalculationResult.Name,
"Tax", // TODO this may not e unqiue (SKU),
1,
taxCalculationResult.TaxAmount,
taxCalculationResult.ExtendedData
};
var attempt = ActivatorHelper.CreateInstance<LineItemBase>(typeof(T), ctrValues);
if (attempt.Success) return attempt.Result as T;
MultiLogHelper.Error<ILineItem>("Failed instiating a line item from invoiceTaxResult", attempt.Exception);
throw attempt.Exception;
}
Is there an easy way to translate this, and change the way the tax name is set?
Just came across the same issue. I was looking to display just the delivery method, 'Royal Mail' in my case, and not 'Shipment - Royal Mail - 1 items'
Maybe it would be better if only the ShipMethod Name was stored as the ShipmentLineItemName, which makes this method redundant, then we could display it any way we want.
Or, if there was a way to override this without changing the core of Merchello?
Yes, but parsing it feels messy and if that text changes in future could break. It doesn't feel right to be hard coded and stored in the line item in the first place, imho
Hardcoded text problems for my dutch webshop
Hi Guys,
I got 2 little issues with some hardcoded text (as seen in the screenshot).
My whole webshop is in Dutch, except these two labels. I just want them to show the name of the shipment (PostNL in this case) and for Tax I want it to show 6% and not Netherlands.
I found out that the shipment line is being set inside the merchello core
And for the Tax i think it is inside this one
Is there an easy way to translate this, and change the way the tax name is set?
Thanks!
Puck
Just came across the same issue. I was looking to display just the delivery method, 'Royal Mail' in my case, and not 'Shipment - Royal Mail - 1 items'
Maybe it would be better if only the ShipMethod Name was stored as the ShipmentLineItemName, which makes this method redundant, then we could display it any way we want.
Or, if there was a way to override this without changing the core of Merchello?
/t
Yeah haven't figured the overriding part out yet. Tried that before i posted this issue
You should be able to modify the view to change that line or parse over it before posting it. I believe the view is InvoiceSummary?
I'm with Tom on this part. It will probably change in the (near) future, so it will break if we parse it.
Yes, but parsing it feels messy and if that text changes in future could break. It doesn't feel right to be hard coded and stored in the line item in the first place, imho
/t
is working on a reply...