I think it might be interesting to hook this package into the SiteDomainHelper to ensure that urls are relative when they can be. SiteDomainHelper was explained by Stephan at CodeGarden, video is here at around 13 minutes.
Thanks for your suggestion. I really appreciate your interest.
I watched Stephen's presesntation, as you suggested, and I think I understand the operation of the SiteDomainHelper, but I wasn't clear on how I should integrate it into this functionality.
It seems that the SiteDomainHelper is used when umbraco generates a page url, in order to represent the correct link when creating a view, etc. The ContextConfig package doesn't really get involved with generating links, however. It only operates on the current page (or the url passed to the function) - the current url (whatever it is) is what is used to lookup the environment & config key.
Have you noticed that ther package doesn't operate correctly in certain cases? I admit I haven't yet tested it with multiple localized sites or otherwise "nested" sites, but since it is using the current page, whatever the displayed domain is should be accurate, right?
If I am misunderstanding your suggestion, please provide a bit of clartification.
Hook up to SiteDomainHelper
Congratulations on really useful package!
I think it might be interesting to hook this package into the SiteDomainHelper to ensure that urls are relative when they can be. SiteDomainHelper was explained by Stephan at CodeGarden, video is here at around 13 minutes.
Hi Jeavon!
Thanks for your suggestion. I really appreciate your interest.
I watched Stephen's presesntation, as you suggested, and I think I understand the operation of the SiteDomainHelper, but I wasn't clear on how I should integrate it into this functionality.
It seems that the SiteDomainHelper is used when umbraco generates a page url, in order to represent the correct link when creating a view, etc. The ContextConfig package doesn't really get involved with generating links, however. It only operates on the current page (or the url passed to the function) - the current url (whatever it is) is what is used to lookup the environment & config key.
Have you noticed that ther package doesn't operate correctly in certain cases? I admit I haven't yet tested it with multiple localized sites or otherwise "nested" sites, but since it is using the current page, whatever the displayed domain is should be accurate, right?
If I am misunderstanding your suggestion, please provide a bit of clartification.
~ Heather
is working on a reply...