Hey Lee,
That's exactly what I'd like to do! I think the part I'm struggling with is retaining the functionality of the UmbracoPropertyAttribute whilst also adding the link to my custom resolver.

Here's what I have so far.

https://gist.github.com/jamiepollock/fc69044cf874bd838d76

The code doesn't actually work mind.

Thanks,
Jamie

Indeed! That's the missing link. :)

For now the case is fairly simple, my use case is for stuff like specifying a target search page for a search form on a website header or in this case where a jobs form posts too.

I'm in the midst of moving over to a new laptop so I'll set up an issue on the repo. Cheers, Lee! I thought I was going barmy or doing something wrong.

Issue created!

Thanks,
Jamie

So long as we're all learning, we all benefit along the way. :)

@Jamie - are you using any other PVCs from the "Umbraco Core Property Value Converters" library?

If not, then as Matt suggests would be a simpler option, as it converts the value early enough in the pipeline.

On a side-note, I'm still interested in following up on extending the UmbracoPropertyAttribute constructor.

Cheers,
- Lee

Just in case you need an example of how to de-register an associated PVC.

protected override void ApplicationStarting(UmbracoApplicationBase umbracoApplication, ApplicationContext applicationContext)
{
    PropertyValueConvertersResolver.Current.RemoveType<MultiNodeTreePickerPropertyConverter>();
}

... and the docs for creating your own PVC:

https://our.umbraco.org/Documentation/Extending/Property-Editors/value-converters

Cheers,
- Lee

@lee, I'm not - so I guess I could go down this route? It feels like a MNTP should convert to single if only one is selected.

Hey Jamie, I'm not sure where was best to reply, here or the GitHub issue comments?

I'll go here :-)

For the simplest approach, with the least amount of custom code, I'd advise this...

• Remove the "Umbraco Core Property Value Converters" library, if you're not using it elsewhere, then you don't need it.

• If all you want is the node's Url property, (taken from here), then try this...

Create a custom TypeConverter that inherits from DittoPickerConverter, then you can override the ConvertFrom method...

public override object ConvertFrom(ITypeDescriptorContext context, CultureInfo culture, object value)
{
    var result = base.ConvertFrom(context, culture, value);

    if (result is IPublishedContent)
        return ((IPublishedContent)result).Url;

    if (result is IEnumerable<IPublishedContent>)
        return ((IEnumerable<IPublishedContent>)result).FirstOrDefault().Url;

    return value;
}

Note: I haven't actually tested this.

Hope this helps?

Cheers,
- Lee

Hey Lee,
This makes a lot of sense. I can't think of any other situation where I'd want anything more than the URL so this probably as complex as the code need be.

As for removing the "Umbraco Core Property Value Converters" project I'll have to see if there is any knock on effect as I'll be using Archetype too.

Thanks,
Jamie

I'm trying to use Lee's TypeConverter code above to map an IPublishedContent returned from MNTP to a custom model however I've come across a stumbling block, a media picker property on the selected MNTP node does not seem to be getting mapped correctly.

The following is my models and the typeconverter code (snipped for brevity). On the "Open Day" document type I have an MNTP property that allows one "University" node to be selected. The University document type has a media picker property on it to select the university's logo.

public class OpenDay : PublishedContentModel
{
    public OpenDay(IPublishedContent content)
        :base(content)
    {}

    [TypeConverter(typeof(UniversityTypeConverter))]
    public University AssociatedUniversity { get; set; }
}


public class University : PublishedContentModel
{
    public University(IPublishedContent content)
        : base(content)
    { }

    public IPublishedContent UniversityLogo { get; set; }
}


public class UniversityTypeConverter : DittoPickerConverter
{
    public override object ConvertFrom(System.ComponentModel.ITypeDescriptorContext context, System.Globalization.CultureInfo culture, object value)
    {
        var result = base.ConvertFrom(context, culture, value);

        if (result is IPublishedContent)
            return ((IPublishedContent)result).As<University>() ;

        if (result is IEnumerable<IPublishedContent>)
            return ((IEnumerable<IPublishedContent>)result).FirstOrDefault().As<University>();

        return value;
    }
}

When I map the "Open Day" node to the model it maps all the properties of both OpenDay and University except for the UniversityLogo property. Does anyone know why this property is no being set.

p.s. I have the Umbraco Property Value Converters installed.

Hi Suzy,

OK, to clarify - the other properties of AssociatedUniversity are populated, except for UniversityLogo?

Just to get it out the way, I'd check for any typos in property-aliases, (sorry, it can happen) :-)

After that, the "universityLogo" property (media-picker) would contain an ID (int), which I'd assume that the 'Umbraco Property Value Converters' package would be picking up and converting to an IPublishedContent.

So looking from your code, everything looks to be wired up correctly.

Let me know if there is a typo ... I'm hoping I'm wrong though.

Cheers,
- Lee

Thinking about it, you might be able to remove the UniversityTypeConverter all together.

With Ditto, if a property returns a single or list of IPublishedContent nodes, then it will check if the POCO's target property is a matching type - if not, then Ditto will attempt to map it to the target type.

It should work - at least that's how we wanted it to work - saves developers having to write custom TypeConverters, etc.

We've got a unit-test to support the scenario...
https://github.com/leekelleher/umbraco-ditto/blob/master/tests/Our.Umbraco.Ditto.Tests/NestedPublishedContentTests.cs

... but I guess other code/packages (real-world things) can come into play. Would be great to have this working for all.

Anyway, glad that your code is working now. Have a good weekend!

Cheers,
- Lee