Hello,

I'm not sure if you are implementing it correct or wrong. Why do you want to cache an ActionResult which you post to? If you cache that the model which gets posted is cached and I don't think you want that. 

Jeroen

Hi Jeroen - Thats the thing - I dont want to cache it.  I want to cache the rest of the page, but I get the above error if I have Donutcaching enabled on the parent surface controller (i.e. the route-hijacked surface controller associated with the doctype).  However, it only happens on post to a child action.

Cheers

Barry

Could you perhaps show the entire controller? It's hard to find out what's wrong now.

Jeroen

Sure, its very simple.  Parent Surface Controller:

public class MemberRegistrationController : SurfaceRenderMvcController

    {

        [DonutOutputCache(CacheProfile = "OneDay")]

        public ActionResult Index()

        {

            var model = ModelLogic.CreateMasterModel() as MasterModel<Models.Generated.MemberRegistration>;

            return CurrentTemplate(model);

        }

        

    }

Child action:

[HttpPost]

        public ActionResult HandleRegisterMember(CustomerModel model)

        {

            if (ModelState.IsValid == false)

            {

                return CurrentUmbracoPage();

            }

            try

            {

                var memberService = Services.MemberService;

                if (memberService.GetByEmail(model.Email) != null)

                {

                    ModelState.AddModelError("DuplicateEmail", "A Member with that email already exists.  Did you mean to <a href='/login'>Login</a>?");

                    return CurrentUmbracoPage();

                }

                var member = RegisterMember(model);

                // Log them in

                FormsAuthentication.SetAuthCookie(member.Username, model.CreatePersistentLoginCookie);

                TempData["FormSuccess"] = true;

            }

            catch (Exception ex)

            {

                // EG: Duplicate email address - already exists

                ModelState.AddModelError("MemberCreate", ex.Message);

            }

            // TODO: Redirect to success (dashboard? cart?) page

            return CurrentUmbracoPage();

        }

 

It doesnt matter what is in the POST action, even just doing a return CurrentUmbracoPage() throws the error.

As I said removing the DonutOutputCache attribute on the parent controller fixes the issue.

Hmm if you look at the contact controller from the best practises you can see something which is exactly the same: https://github.com/jbreuer/Hybrid-Framework-for-Umbraco-v7-Best-Practises/blob/master/Umbraco.Extensions/Controllers/ContactController.cs

That just works so I don't why you are getting this error now.

Jeroen

The difference is I am rendering my form via an action method on my template:

@Html.Action("RenderRegistrationForm","Registration",true)

Sorry, I should have posted the code for that action method before.  Again its very simple, creates a model and returns a partial view.

[ChildActionOnly]

        public ActionResult RenderRegistrationForm()

        {

            //Create a new Login View Model

            var customerModel = new CustomerModel();

            return PartialView("Member/Register", customerModel);

        }

 

In the Hybrid Framework the contact form is embedded directly into the template, so it would never be able to be 'donut-holed' (I dont think?)  So, for example, if this was a login form there would be no way to exclude it from the cache while ensuring the rest of the page was cached.

 

 

 

Yes that is a difference. Why does you register form needs to be 'donut-holed'?

Jeroen

Let's say the user is already logged in, I might like to redirect to the 'member dashboard' action. 

It would be the same deal for a login form where there might be lots of other content on the page that would be useful to have cached.  

On his blog post he specifically talks about donut caching login forms so I don't think its a bug in the tool itself.  Could be something upstream in Umbraco but chances are I'm just not doing it right!  WIll test in pure MVC tomorrow and report.

Hello,

Did you test it with a pure MVC and did that work?

Jeroen

Hi Jeroen,

I'm on another project atm but I will get back on this later in the week and feedback any info, cheers.

Good to hear you've got it fixed!

This worked for me as well. Thanks Bary. HFYR

/Rune

is working on a reply...