Copied to clipboard

Flag this post as spam?

This post will be reported to the moderators as potential spam to be looked at


  • Barry Fogarty 493 posts 1129 karma points
    May 30, 2014 @ 12:48
    Barry Fogarty
    1

    v7 version - incompatibility with umbracoInternalRedirectId

    Hi Jeavon,

    Loving this little package.  Would you mind updating the v7 version so it does not convert an umbracoInternalRedirectId alias property?

  • Jeavon Leopold 3042 posts 13382 karma points MVP 8x admin c-trib
    May 30, 2014 @ 12:51
    Jeavon Leopold
    0

    I have that in there already for the Content Picker from the v6 version, are you using that?

    I've not tested it so maybe it's not working the same way in v7....

  • Barry Fogarty 493 posts 1129 karma points
    May 30, 2014 @ 12:53
    Barry Fogarty
    0

    Yep - not working the same way in the v7 version.  I'm on Umbraco 7.1.3

  • Jeavon Leopold 3042 posts 13382 karma points MVP 8x admin c-trib
    May 30, 2014 @ 12:55
    Jeavon Leopold
    0

    Ok, I'll investigate. Are you using v2.0.2?

  • Barry Fogarty 493 posts 1129 karma points
    May 30, 2014 @ 12:57
    Barry Fogarty
    0

    Yes. I was on v2.0.0 but just updated.  Same behaviour with both, no redirection takes place.

  • Jeavon Leopold 3042 posts 13382 karma points MVP 8x admin c-trib
    May 30, 2014 @ 12:58
    Jeavon Leopold
    0

    Ah wait, have you enabled it in umbracoSettings.config?

  • Jeavon Leopold 3042 posts 13382 karma points MVP 8x admin c-trib
    May 30, 2014 @ 13:03
    Jeavon Leopold
    0

    Nope, it's not that, investigating further

  • Jeavon Leopold 3042 posts 13382 karma points MVP 8x admin c-trib
    May 30, 2014 @ 13:12
  • Barry Fogarty 493 posts 1129 karma points
    May 30, 2014 @ 13:39
    Barry Fogarty
    0

    Sorry, spoke a bit too soon.  I have an Archetype-based Multi URL picker on this site and with the previous version of PEVC the following code works ok:

    prop.GetValue<IPublishedContent>("nodeId");

    prop is of type ArchetypeFieldsetModel.  With the new DLL there is a null ref error.

    [NullReferenceException: Object reference not set to an instance of an object.]
       Our.Umbraco.PropertyConverters.ContentPickerPropertyConverter.ConvertDataToSource(PublishedPropertyType propertyType, Object source, Boolean preview) +183
       Archetype.Models.ArchetypePropertyModel.TryConvertWithPropertyValueConverters(Object value, IEnumerable`1 converters) +201
       Archetype.Models.ArchetypePropertyModel.GetValue() +133
       Archetype.Models.ArchetypeFieldsetModel.GetValue(String propertyAlias)
  • Jeavon Leopold 3042 posts 13382 karma points MVP 8x admin c-trib
    May 30, 2014 @ 13:46
    Jeavon Leopold
    0

    and it wasn't there with the previous version?

  • Jeavon Leopold 3042 posts 13382 karma points MVP 8x admin c-trib
    May 30, 2014 @ 13:47
    Jeavon Leopold
    0

    I think the value must be null coming into the converter, I will put in a handler for that

  • Jeavon Leopold 3042 posts 13382 karma points MVP 8x admin c-trib
    May 30, 2014 @ 13:50
    Jeavon Leopold
    0

    Ok, I've updated the DLL in the dropbox, could you try it out?

  • Barry Fogarty 493 posts 1129 karma points
    May 30, 2014 @ 14:22
    Barry Fogarty
    0

    That still behaves the same way.  To clarify my previous message, the property with alias "nodeId" within the archetype property does have a value, so its not just a null check issue.  All I can say is the ArchetypeFieldsetModel's GetValue<T> method plays nicely with the v2.0.2 version, but this update with umbracoInternalRedirectId seems to break it.

    I can send you a zipped site if easier?  Its SQL CE.

  • Jeavon Leopold 3042 posts 13382 karma points MVP 8x admin c-trib
    May 30, 2014 @ 15:27
    Jeavon Leopold
    0

    Hey Barry,

    Strange, a zip would be great, DM me on Twitter with a link if you prefer to public posting.

    Cheers,

    Jeavon

  • Jeavon Leopold 3042 posts 13382 karma points MVP 8x admin c-trib
    May 30, 2014 @ 18:15
    Jeavon Leopold
    0

    Hey Barry,

    I found the issue, Archetype doesn't send a PropertyTypeAlias, so I can't check for umbracoInternalRedirectId. This should now be handled in the latest version on drop box. https://dl.dropboxusercontent.com/u/14453377/Our.Umbraco.PropertyEditorConverters.zip

    Let me know.

    Jeavon

  • Barry Fogarty 493 posts 1129 karma points
    May 30, 2014 @ 18:36
    Barry Fogarty
    0

    So do you mean you are not able to check for umbracoInternalRedirectId in any situation?  This version works with Archetype but does not resolve the original issue with umbracoInternalRedirectId.  Not to worry, if its not possible I will just change the umbracoInternalRedirectId to a nemeric field.

  • Jeavon Leopold 3042 posts 13382 karma points MVP 8x admin c-trib
    May 30, 2014 @ 18:50
    Jeavon Leopold
    1

    Ok, I have just updated the dropbox again, I think we've got it this time for all usages...?

  • Barry Fogarty 493 posts 1129 karma points
    May 30, 2014 @ 19:10
    Barry Fogarty
    0

    Thats the puppy!  Nice one, beer for you at CG14.

  • Jeavon Leopold 3042 posts 13382 karma points MVP 8x admin c-trib
    May 30, 2014 @ 19:11
    Jeavon Leopold
    0

    Awesome! I will add a new release! See you at CG14.

Please Sign in or register to post replies

Write your reply to:

Draft