Copied to clipboard

Flag this post as spam?

This post will be reported to the moderators as potential spam to be looked at


  • schlubadub 102 posts 617 karma points
    Mar 17, 2015 @ 10:52
    schlubadub
    0

    I was curious about how you'd handled the Foundation framework, as I made my own grid for this a couple of weeks ago for my own project...

    I just noticed a couple of items:

    It's good you have a baseColSize variable, but this should be set to "small" by default, as Foundation has a "mobile first" mentality. But it's good you let the user decide. For the same reason you should use the baseColSize everywhere instead of hard-coding it to use "large" in 2 places: class="[email protected] columns column" and class="[email protected] columns column"

    You don't need to put columns column together as only columns is needed (Reference: http://foundation.zurb.com/docs/components/grid.html)

    Also, "xlarge" and "xxlarge" aren't used for the grid - only small, medium, large

    I can post my full grid if you're interested, but I did a few more things like getting rid of all "clearfix" references, and I dropped the "umb-grid" divs completely.

  • Jason 113 posts 628 karma points
    Mar 17, 2015 @ 14:45
    Jason
    100

    Thanks for the feedback and catching the baseColSize issue, bad repo auto merge when I added Skeleton and Gumby to the project. That was one of those things that still works even though it is wrong. Thought I would be clever and try TFS this time, going back to GIT.

    I have to admit that I am not that familiar with Foundation so I updated the column suggestions to just the three sizes, miss understood the media query breakpoints and assumed that those were column options, my bad :-).

    I am going with medium for Foundation as the base column size so that that the grid will collapse on on smaller screens. I did also remove the extra 'column' class, leftover from the Bootstrap3 renderer, you are right it is not needed.

    Version 1.1 uploaded.

  • Thomas 267 posts 548 karma points c-trib
    Sep 14, 2017 @ 13:03
    Thomas
    0

    Hi schlubadub

    How do you implement foundation ? Where did you get the foundation grid file?

    // Thomas

Please Sign in or register to post replies

Write your reply to:

Draft