I was curious about how you'd handled the Foundation framework, as I made my own grid for this a couple of weeks ago for my own project...
I just noticed a couple of items:
It's good you have a baseColSize variable, but this should be set to "small" by default, as Foundation has a "mobile first" mentality. But it's good you let the user decide. For the same reason you should use the baseColSize everywhere instead of hard-coding it to use "large" in 2 places: class="[email protected] columns column" and class="[email protected] columns column"
Also, "xlarge" and "xxlarge" aren't used for the grid - only small, medium, large
I can post my full grid if you're interested, but I did a few more things like getting rid of all "clearfix" references, and I dropped the "umb-grid" divs completely.
Thanks for the feedback and catching the baseColSize issue, bad repo auto merge when I added Skeleton and Gumby to the project. That was one of those things that still works even though it is wrong. Thought I would be clever and try TFS this time, going back to GIT.
I have to admit that I am not that familiar with Foundation so I updated the column suggestions to just the three sizes, miss understood the media query breakpoints and assumed that those were column options, my bad :-).
I am going with medium for Foundation as the base column size so that that the grid will collapse on on smaller screens. I did also remove the extra 'column' class, leftover from the Bootstrap3 renderer, you are right it is not needed.
Foundation Framework
I was curious about how you'd handled the Foundation framework, as I made my own grid for this a couple of weeks ago for my own project...
I just noticed a couple of items:
It's good you have a baseColSize variable, but this should be set to "small" by default, as Foundation has a "mobile first" mentality. But it's good you let the user decide. For the same reason you should use the baseColSize everywhere instead of hard-coding it to use "large" in 2 places:
class="[email protected] columns column"andclass="[email protected] columns column"You don't need to put
columns columntogether as onlycolumnsis needed (Reference: http://foundation.zurb.com/docs/components/grid.html)Also, "xlarge" and "xxlarge" aren't used for the grid - only small, medium, large
I can post my full grid if you're interested, but I did a few more things like getting rid of all "clearfix" references, and I dropped the "umb-grid" divs completely.
Thanks for the feedback and catching the baseColSize issue, bad repo auto merge when I added Skeleton and Gumby to the project. That was one of those things that still works even though it is wrong. Thought I would be clever and try TFS this time, going back to GIT.
I have to admit that I am not that familiar with Foundation so I updated the column suggestions to just the three sizes, miss understood the media query breakpoints and assumed that those were column options, my bad :-).
I am going with medium for Foundation as the base column size so that that the grid will collapse on on smaller screens. I did also remove the extra 'column' class, leftover from the Bootstrap3 renderer, you are right it is not needed.
Version 1.1 uploaded.
Hi schlubadub
How do you implement foundation ? Where did you get the foundation grid file?
// Thomas
is working on a reply...
This forum is in read-only mode while we transition to the new forum.
You can continue this topic on the new forum by tapping the "Continue discussion" link below.