Copied to clipboard

Flag this post as spam?

This post will be reported to the moderators as potential spam to be looked at


  • Anthony Dang 1404 posts 2558 karma points MVP c-trib
    Oct 01, 2014 @ 12:17
    Anthony Dang
    1

    2 issues/bugs/quirks

    1. Deleing the uSync folder causes all the definitions are re-created, even if write=false.

    This didnt occur before, and I don't think this should be desired functionality. We often delete the folders inside the uSync folder, and it would be nice for it to obey the write=false setting

     

    2. Templates that already exist will cause uSycn to YSOD

    Scenario 1: When you create a template in the backoffice, uSync creates a def file. When you move that template, the original def file exists, along with the new one. This causes a YSOD. 

    Scenario 2: A template exists at the root level of a target Umbraco instance. A new uSync def of the same name under a different parent exists in a deployment (probably a developer wanted to move the template to be a child of another). This causes a YSOD.

    I think rather than YSODing, a better thing to do would be to fail silently, and log the error. You could even perhaps show the error in a backoffice tab. But I think more importantly, the YSOD should be removed, as it causes the entire site to be not startable. 

     

     

     

  • Kevin Jump 1496 posts 9565 karma points MVP 3x c-trib
    Oct 01, 2014 @ 14:50
    Kevin Jump
    0

    Im not sure about the first one: most of the time uSync needs to do a write on first run, because it need to catch up with the state of the current installation.

    It only checks for the existance of the usync folder so if you create (or don't delete) an empty usync directory then usync will do nothing - (i suppose i could add a 'coldstart' setting or something similar - but the default will probibly always be write when the folder is missing)

    Second one - yes - uSync doesn't cope well with renames at the moment.

    I have been considering putting some status stuff into the dashboard - there should be a don't ever YSOD setting in the config: if dontThrowErrors=true and you still get the YSDO then i've done something wrong somewhere.

  • Anthony Dang 1404 posts 2558 karma points MVP c-trib
    Oct 02, 2014 @ 12:35
    Anthony Dang
    0

    Regarding dontThrowErrors, I probably should have mentioned that we're on umb 6.1.6 for this site, so it's uSync 1.5.8.2. I just noticed that only the v7 version has that.

     

    Regarding the folder...

    I'm not sure I understand why the folder needs to exist.

    If read=true and it isnt there, then do nothing.

    if write/attach=true an and it isnt there, then create it. 

    The issue is that when write=false, and the folder doesnt exist, then it writes everything. I think devs are savvy enough to know that if they want the defs all written, then they should modify the config. It's not that big of a deal though, but just thought I'd flag it.

     

  • Kevin Jump 1496 posts 9565 karma points MVP 3x c-trib
    Oct 02, 2014 @ 13:15
    Kevin Jump
    0

    yeah i think you are right, if Attach is also false then it shouldn't create the folder. I was stuck in the it needs to be there so you get a complete picture- but if you're not doing attach then that never matters.

Please Sign in or register to post replies

Write your reply to:

Draft