Sign in Register
Go to solution
Copied to clipboard

Flag this post as spam?

This post will be reported to the moderators as potential spam to be looked at


  • Jason Prothero 422 posts 1243 karma points c-trib
    Jul 19, 2010 @ 22:53
    Jason Prothero
    0

    Missed one conversion

    General

    Hey, great job on the package!  Huge help.

    I found one thing it consistently didn't convert:

    $parent/node [string(./umbracoSitemapHide) != '1' and @level <= $maxLevelForSitemap]

    The /node above doesn't work. 

    I converted it to this and it works:

    $parent/*[@isDoc] [string(./umbracoSitemapHide) != '1' and @level <= $maxLevelForSitemap]

     

    Let me know if this is the appropriate way to do this or if there is better syntax.

    Thanks!

    Copy Link
  • Jason Prothero 422 posts 1243 karma points c-trib
    Jul 19, 2010 @ 23:22
    Jason Prothero
    0

    Looks like the sitemap template uses something like this:

    $parent/* [@isDoc and string(umbracoNaviHide) != '1' and @level <= $maxLevelForSitemap]

    So my above code would be:

    $parent/* [@isDoc and string(umbracoSitemapHide) != '1' and @level <= $maxLevelForSitemap]

     


    Copy Link
  • Markus Klug 5 posts 101 karma points
    Jul 21, 2010 @ 09:31
    Markus Klug
    1

    Hi Jason, I'm the author of the converter, Thomas Höhler packaged it for me.

    The problem with your suggestion is that replacing "$parent/node" with "$parent/*[@isDoc]" will cause problems if the <node> in question was a media-node. And as far as I can see right now, there is no easy way to determine this.

    One solution to work around this to give the user the option to run the converter in two different "modes", like "Documents" mode and "Media" mode.

    I'll give this some thought and update the package in the next couple of days...

    Copy Link
  • Jason Prothero 422 posts 1243 karma points c-trib
    Jul 21, 2010 @ 17:37
    Jason Prothero
    0

    Hi Markus,

    I figured there was a reason.  BTW, thanks for the package, it helps a ton.  Its good to know all of the exceptions so I can make a second pass after your converter finishes.

    Thanks again for the effort and I'm happy test any further releases for you.

     

    Thanks,
    Jason

    Copy Link
Please Sign in or register to post replies

Write your reply to:

Draft