The ##CommenterEmail## placeholder does not work when used with the comment notification template, it works fine in the other 2 templates. Is this an oversight/bug or is it designed that way?
I'm sorry but I've been away on holiday and only just got back. My initial test didn't work just before I left and I thought I'd try a bit more carefully whe I returned. We have tried again replacing the DLLs but get a custom error message when we try to make a comment ('an error has occurred'). I'm not sure how to try and debug this further but the old DLLs don't give the same error.
at uBlogsy.BusinessLogic.CommentService.CreateComment(HttpRequest request, Int32 pageId, CommentInfo commentInfo) in D:\_PROJECTS\Personal\uBlogsy\Branches\2.1.1.0\uBlogsy\uBlogsy.BusinessLogic\CommentService.cs:line 171
at uBlogsy.BusinessLogic.CommentService.SubmitComment(HttpRequest request, Int32 pageId, CommentInfo commentInfo, Boolean subscribe) in D:\_PROJECTS\Personal\uBlogsy\Branches\2.1.1.0\uBlogsy\uBlogsy.BusinessLogic\CommentService.cs:line 109
I've been waiting to try with the very latest version (2.1.1.1). I have republished everything, I've also recycled the app pool to make sure the cache file is rebuilt but I still get an error with the new DLLs.
I replaced all the uBlogsy DLLs and the akismet one as well (we don't use it though). When I post a comment I get an error message (in the page) and in the log:
Object reference not set to an instance of an object.
at uHelpsy.Core.UmbracoAPIHelper.UpdateDocumentProperties(Document doc, Dictionary`2 properties)
at uHelpsy.Core.UmbracoAPIHelper.UpdateContentNode(Document doc, Dictionary`2 properties, Boolean publish)
at uBlogsy.BusinessLogic.CommentService.CreateComment(HttpRequest request, Int32 pageId, CommentInfo commentInfo)
at uBlogsy.BusinessLogic.CommentService.SubmitComment(HttpRequest request, Int32 pageId, CommentInfo commentInfo, Boolean subscribe)
Somthing in the new DLLs is not compatible with what we have 'somewhere' in the site, the old DLLs work fine when replaced in the site except that they don't replace the ##commenteremail## placeholder in the emails.
I'm sorry but I'm a bit of a newbie with Umbraco and we don't yet understand all the wrinkles of how things interact so I'm sure it's me being stupid or naive but I don't know where ??
Email Template placeholder not working
The ##CommenterEmail## placeholder does not work when used with the comment notification template, it works fine in the other 2 templates. Is this an oversight/bug or is it designed that way?
That was left out on purpose because I didnt think sending email address of commenters to other commenters was a good idea.
However, I'll add it to the next release. If you want to use it then you can.
Hopefully will get at least a beta release out this weekend.
-Anthony
Thanks Anthony that's great.
Hello Anthony,
It seems that the admin comment notification template also has a problem with ##CommenterEmail##. Is that covered in the update as well?
It works for me.
Are you sure you're editing the correct email template node in the content tree?
Can you paste a screenshot?
This is the HTML from Admin Comment Notification:
<p>##CommenterName## has left a comment on the post <a href="##PostUrl##">##PostTitle##</a>...</p>
<p> </p>
<p>Sender email: ##CommenterEmail##</p>
<p style="border-top: 1px dotted lightgrey; border-bottom: 1px dotted lightgrey; padding: 10px 0px;"><span>"</span>##CommentBody##<span>"</span></p>
<p style="color: grey; font-size: 10px;">If auto publishing of comments is not enabled, you need to log in to publish the comment.</p>
<p style="color: lightgrey; font-size: 10px; float: right;">Powered by uBlogsy and Umbraco</p>
Does that look right?
If you want to email me directly I can give you a direct log in to the admin area.
Regards
Roger
Did you delete the old dll's first?
Also, I noticed that the old xml template file is still in the package...it's not being used... is this coming from there or from the content node?
Sorry Anthony,
I hadn't changed the DLLs yet as I thought this template was working. Did you update this template too in the new DLL?
The HTML is from the content node.
Roger
The old xml template file is still in the package - ignore it.
What replaces the tokens in the content node templates is the dlls.
Replace the dlls and it should work.
Thanks Anthony - trying it now.
Regards and thanks
Hi Anthony,
I'm sorry but I've been away on holiday and only just got back. My initial test didn't work just before I left and I thought I'd try a bit more carefully whe I returned. We have tried again replacing the DLLs but get a custom error message when we try to make a comment ('an error has occurred'). I'm not sure how to try and debug this further but the old DLLs don't give the same error.
Any thoughts?
Regards
Roger
What does the umbracoLog table say?
Object reference not set to an instance of an object.
at uHelpsy.Core.UmbracoAPIHelper.UpdateDocumentProperties(Document doc, Dictionary`2 properties)
at uHelpsy.Core.UmbracoAPIHelper.UpdateContentNode(Document doc, Dictionary`2 properties, Boolean publish)
at uHelpsy.Core.UmbracoAPIHelper.CreateContentNode(String nodeName, String nodeTypeAlias, Dictionary`2 properties, Int32 parentId, Boolean publish)
at uBlogsy.BusinessLogic.CommentService.CreateComment(HttpRequest request, Int32 pageId, CommentInfo commentInfo) in D:\_PROJECTS\Personal\uBlogsy\Branches\2.1.1.0\uBlogsy\uBlogsy.BusinessLogic\CommentService.cs:line 171
at uBlogsy.BusinessLogic.CommentService.SubmitComment(HttpRequest request, Int32 pageId, CommentInfo commentInfo, Boolean subscribe) in D:\_PROJECTS\Personal\uBlogsy\Branches\2.1.1.0\uBlogsy\uBlogsy.BusinessLogic\CommentService.cs:line 109
Any further news on this Anthony?
Regards
Roger
Have you tried re-publishing everything?
Hi Anthony,
I've been waiting to try with the very latest version (2.1.1.1). I have republished everything, I've also recycled the app pool to make sure the cache file is rebuilt but I still get an error with the new DLLs.
I replaced all the uBlogsy DLLs and the akismet one as well (we don't use it though). When I post a comment I get an error message (in the page) and in the log:
Object reference not set to an instance of an object.
at uHelpsy.Core.UmbracoAPIHelper.UpdateDocumentProperties(Document doc, Dictionary`2 properties)
at uHelpsy.Core.UmbracoAPIHelper.UpdateContentNode(Document doc, Dictionary`2 properties, Boolean publish)
at uHelpsy.Core.UmbracoAPIHelper.CreateContentNode(String nodeName, String nodeTypeAlias, Dictionary`2 properties, Int32 parentId, Boolean publish)
at uBlogsy.BusinessLogic.CommentService.CreateComment(HttpRequest request, Int32 pageId, CommentInfo commentInfo)
at uBlogsy.BusinessLogic.CommentService.SubmitComment(HttpRequest request, Int32 pageId, CommentInfo commentInfo, Boolean subscribe)
Somthing in the new DLLs is not compatible with what we have 'somewhere' in the site, the old DLLs work fine when replaced in the site except that they don't replace the ##commenteremail## placeholder in the emails.
I'm sorry but I'm a bit of a newbie with Umbraco and we don't yet understand all the wrinkles of how things interact so I'm sure it's me being stupid or naive but I don't know where ??
2.1.1.1 is now available but I'm pretty sure it doesnt solve your issue.
Did you delete or rename any properties?
Perhaps you can try installing a fresh copy of Umbraco and ublogsy.
Then package up the old content tree, and install it into the new installation.
Arg! I figured out the problem.
Sorry I forgot to add something crucial to the upgrade instructions... Majorly crucial!
Add a date time property to the comment doc type with alias: uBlogsyCommentDate
Then do a full publish.
Hopefully that will fix everything. Sorry again.
Hi Anthony,
That looks like the right kind of thing. I'll check it out tomorrow night when I can get access to my clients system.
Thanks for sticking with this one.
Regards
Roger
Thanks Anthony, that was perfect. Got in to test it tonight and it worked perfectly.
Thanks again
Roger
Good to hear. Sorry again for the oversight.
is working on a reply...