Only tiny error tough - the thumbnails is created wrong.
When setting the thumbnail size on the upload datatype in Umbraco and uploads manually Umbraco takes this/theese size(s) for the width of the image. Your package set the size for the hight of the image.
I've just looked into this, and I belive this is the correct functionality. The prevalues you define on the upload data type are a max width/height combo, not just width. So the generated thumbnail will be resized to fit within a box that size, meaning if your image is portrait, it will resize the height to fit, and if it's landscape, it will resize the width.
I've checked the source, and this is indeed how the media upload data type works, and if you also read the label for the prevalue, it reads:
Thumbnail sizes (max width/height, semicolon separated for multiples):
Bug creating thumbnails
Hi Matt,
Great package - It works really really well.
Only tiny error tough - the thumbnails is created wrong.
When setting the thumbnail size on the upload datatype in Umbraco and uploads manually Umbraco takes this/theese size(s) for the width of the image. Your package set the size for the hight of the image.
/cheers
Ooops.
Thanks Soren. I'll get that sorted in the next upload.
Cheers
Matt
Hi Soren,
I've just looked into this, and I belive this is the correct functionality. The prevalues you define on the upload data type are a max width/height combo, not just width. So the generated thumbnail will be resized to fit within a box that size, meaning if your image is portrait, it will resize the height to fit, and if it's landscape, it will resize the width.
I've checked the source, and this is indeed how the media upload data type works, and if you also read the label for the prevalue, it reads:
Unless I've misunderstood the issue?
Many thanks
Matt
Hi Matt,
I think you are right. No need to change anytihng then.
cheers.
/Søren
is working on a reply...