Hi Zac,

Which version of uCommerce 2 are you running?

Hi Søren,

version 2.0.1.0

Hi Zac,

I had to do a little digging to find the issue. Turns out there was a bug in uCommerce which caused it to keep the old id around until a subsequent request. I fixed it and release uCommerce 2.0.4.0 for you. Please download it and let me know how you get on with it.

Regarding the other issue with the wrong total I'm going to need some more information before I can figure out what's going on.

Could you include the full order XML and let me know which values are wrong, what you expected them to be, and what your shipping method/VAT config is for the methods in play?

Thanks.

Many thanks Søren.

I've had a go with this version (overwrote all the DLL files). Now I have the correct shipping id (before only the correct shipping name was coming up), but the price still seems to be wrong:

<shipment index="0" shipmentId="860" name="Premier Delivery" 
   createdDate="24/08/2011 09:19:00" shippingMethodId="10" 
   deliveryNote="" trackAndTrace="" price="3.95" taxRate="0.00" 
   tax="0.00" shipmentTotal="3.95">

The price should be £6.95. If I refresh the page (and re-post), it will then be correct, and the correct total will be there too.

When I said the incorrect order total going through to SagePay, I meant the total was incorrect because it had the wrong shipping charge (so, the same issue, there's no other issue with the total as far as I know!).

Cheers,

Zac

Hi Zac,

Are you executing the basket pipeline before you make a call to GetBasket()?

Well, I'm doing that in the UpdateShipping xslt template which gets called before the basket one. So yes...

However...

I'm not calling GetBasket in what you'd call the order details page, I'm using CommerceLibrary:GetPurchaseOrder:

  <xsl:variable name="orderGuid" select="umbraco.library:Session('orderGuid')"/>
  <xsl:variable name="cart" select="CommerceLibrary:GetPurchaseOrder($orderGuid)"/>

Perhaps this explains the difference? The purchase order isn't getting updated anymore, even if the basket is?

The reason we're using the orderGuid? If memory serves, because it's the same template that the user sees when the come back from SagePay and by then the basket is empty.

Cheers,

Zac

The two APIs will produce the same XML structure so that's not it.

Is there a way I can take a look at the XSLT itself?

Certainly:

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE xsl:stylesheet [
  <!ENTITY nbsp "&#x00A0;">
]>
<xsl:stylesheet
  version="1.0"
  xmlns:xsl="http://www.w3.org/1999/XSL/Transform"
  xmlns:msxml="urn:schemas-microsoft-com:xslt"
  xmlns:umbraco.library="urn:umbraco.library"
  xmlns:CommerceLibrary="urn:CommerceLibrary"
  xmlns:Business="urn:Business"
  exclude-result-prefixes="msxml umbraco.library CommerceLibrary Business">

  <xsl:output method="xml" omit-xml-declaration="yes"/>
  <xsl:param name="currentPage"/>

  <xsl:variable name="orderGuid" select="umbraco.library:Session('orderGuid')"></xsl:variable>
  <xsl:variable name="cart" select="CommerceLibrary:GetPurchaseOrder($orderGuid)"/>

  <xsl:template match="/">
    <style type="text/css">
      p { padding:8px 0;}
    </style>
    debug: <textarea><xsl:copy-of select="$cart"/></textarea> 
    <xsl:apply-templates select="$cart/purchaseOrder"></xsl:apply-templates>
  </xsl:template>

  <xsl:template match="purchaseOrder">
    <xsl:if test="@orderNumber != ''">
      <p>
        Order reference number: <strong>
          <xsl:value-of select="@orderNumber"/>
        </strong>
      </p>
    </xsl:if>
    <p>
      <strong>Customer</strong>
    </p>
    <xsl:apply-templates select="billingAddress/address"/>
    <xsl:for-each select="shipments/shipment">

      <p>
        <strong>
          <xsl:variable name="surcharge" select="Business:GetSurcharge(address/@postalCode)"/>
          Shipping with <xsl:value-of select="@name"/>: £<xsl:value-of select="format-number(@price - $surcharge,'0.00')"/>
          <xsl:if test="$surcharge &gt; 0">
            (plus £<xsl:value-of select="format-number($surcharge,'0.00')"/>&nbsp;<a href="/delivery-information">regional delivery surcharge</a>)
          </xsl:if>
        </strong>
      </p>
      <xsl:apply-templates select="address"/>
    </xsl:for-each>
    <p>
      <strong>Special Delivery Instructions:</strong>&nbsp;<xsl:value-of select="$cart/purchaseOrder/billingAddress/address/@attention"/>
    </p>
    <p>
      <strong>Order Summary</strong>
    </p>
    <xsl:call-template name="lineItems"></xsl:call-template>
  </xsl:template>

  <xsl:template name="lineItems">
    <table class="basket">
      <thead>
        <tr>
          <td class="item">Item no.</td>
          <td class="desc">Description</td>
          <td class="price">Item price</td>
          <td class="vat">VAT</td>
          <td class="quant">Quantity</td>
          <td class="total">Total (inc VAT)</td>
        </tr>
      </thead>
      <tbody>
        <xsl:for-each select="$cart/purchaseOrder/lineItems/lineItem">
          <tr>
            <td class="item">
              <xsl:value-of select="@sku"/>
            </td>
            <td class="desc">
              <xsl:value-of select="@productName"/>
            </td>
            <td class="price">
              £<xsl:value-of select="CommerceLibrary:FormatCurrency(@price)"/>
            </td>
            <td class="vat">
              £<xsl:value-of select="CommerceLibrary:FormatCurrency(@price * @vatRate)"/>
            </td>
            <td class="quant">
              <xsl:value-of select="@quantity"/>
            </td>
            <td class="total">
              <xsl:choose>
                <xsl:when test="@unitDiscount != 0">
                  <xsl:variable name="discountVat" select="(@price + (@price * @vatRate)) - @total"></xsl:variable>
                  <span style="text-decoration:line-through">
                    £<xsl:value-of select="CommerceLibrary:FormatCurrency(@total + $discountVat)"/>
                  </span>&nbsp;
                  £<xsl:value-of select="CommerceLibrary:FormatCurrency(@total)"/>
                </xsl:when>
                <xsl:otherwise>
                  £<xsl:value-of select="CommerceLibrary:FormatCurrency(@total)"/>
                </xsl:otherwise>
              </xsl:choose>
            </td>
          </tr>
          <xsl:call-template name="discountTemplate">
            <xsl:with-param name="discounts" select="discounts"/>
            <xsl:with-param name="id" select="@index"/>
            <xsl:with-param name="vatRate" select="@vatRate"/>
          </xsl:call-template>

        </xsl:for-each>
        <tr>
          <td colspan="5">Sub total:</td>
          <td>
            £<xsl:value-of select="CommerceLibrary:FormatCurrency(@subTotal + @vat)"/>
          </td>
        </tr>
      </tbody>
      <tfoot>
        <tr>
          <td colspan="5">Order total with delivery:</td>
          <td>
            £<xsl:value-of select="CommerceLibrary:FormatCurrency(@orderTotal)"/>
          </td>
        </tr>
      </tfoot>
    </table>
  </xsl:template>

  <xsl:template match="address">
    <p>
      Name: <xsl:value-of select="@firstName"/>&nbsp;<xsl:value-of select="@lastName"/><br/>
      <xsl:if test="@company != ''">
        Company: <xsl:value-of select="@company"/>
        <br/>
      </xsl:if>
      <xsl:value-of select="@line1"/><br/>
      <xsl:if test="@line2 != ''">
        <xsl:value-of select="@line2"/>
        <br/>
      </xsl:if>
      <xsl:value-of select="@city"/><br/>
      <xsl:value-of select="@postalCode"/><br/>
      <xsl:value-of select="@country"/>
      <xsl:if test="@emailAddress != ''">
        <br/>E-mail: <xsl:value-of select="@emailAddress"/>
      </xsl:if>
    </p>
  </xsl:template>

  <xsl:template name="discountTemplate">
    <xsl:param name="discounts" />
    <xsl:param name="id" />
    <xsl:param name="vatRate" />
    <xsl:if test="count($discounts/discount) > 0">
      <xsl:for-each select="$discounts/discount">
        <tr>
          <xsl:attribute name="class">
            discount_<xsl:value-of select="$id" />
          </xsl:attribute>
          <td></td>
          <td class="note" colspan="4">
            <xsl:value-of select="@campaignName"/> - <xsl:value-of select="@campaignItemName"/>
          </td>
          <td class="total">
            -£<xsl:value-of select="format-number( @amountOff + (@amountOff * $vatRate),'0.00')"/>
          </td>
        </tr>
      </xsl:for-each>
    </xsl:if>
  </xsl:template>
  
</xsl:stylesheet>

Just for the hell of it: Could you try and put in a call to CommerceLibrary:ExecuteBasketPipeline() just before you do GetBasket/GetPurchaseOrder in that macro?

I'd actually already given that a go, but I just tried it again since updating the version, still no luck.

For the record, I only replaced the .DLL files from the new version of uCommerce, I didn't update anything else. Hope that's not part of the problem?

Sorry, weird XSLT error double post. Damn Our Umbraco!

Hi Zac,

Would it be possible to take a look at the site directly? If you could send me a copy of your website and database, I'd be happy to try and dig through it to repro the issue you're seeing.

Thanks.

is working on a reply...