Hi Thomasz,

There shouldn't be any timing issue as all changes are committed as soon as the last open UoW has it's Complete() method called and as mentioned in the other issue, I do think the setting of default payment method should actually be working.

When you say it appears after 15 seconds, could this actually be after an app pool recycle? If so, there may be a problem with the caching layer not getting updated, but the order is actually persisting. I'm not sure why this would be the case though.

If you don't have the demo store events setup, then they won't be being used at all so that shouldn't be the problem. Though I'm not currently sure why you are seeing the issues you are.

If you recycle the app pool, is there order as you would expect it to be?

Hi Matt,

I tried something else. I removed setting shipping method from this piece of code:

if (order.PaymentInfo.PaymentMethodId == null)
                {
                    var paymentAlias = "bambora";
                    if (Request.Url.AbsoluteUri.Contains("localhost"))
                    {
                        paymentAlias = "invoicing";
                    }
                    var pm = _paymentMethodService.GetPaymentMethod(store.Id, paymentAlias);
                    order.SetPaymentMethod(pm);
                }

                if (order.ShippingInfo.ShippingMethodId == null)
                {
                    var shm = _shippingMethodService.GetShippingMethod(store.Id, "electronic");
                    order.SetShippingMethod(shm);
                }

And it seems to be working now. Could it be that setting the shippingMethodId i same transaction as paymentMethodId, removes the latter???

I will test it more tomorrow, I'm done for today...

Anyway, thank You for help :)

/Tomasz

Yes, it's very strange. I'm trying to find the pattern.

When both shipping and payment are null and I'm setting them in a one uow "session", only shipping Id is saved, but when call this piece of code once more (reload) having shipping not null and payment null, payment is being saved as well. And I'm not even checking if I already have payment/shipment ID:

    public ActionResult PreprocessOrder()
    {
        try
        {
            using (var uow = _uowProvider.Create())
            {
                var store = CurrentPage.GetStore();
                var order = _sessionManager.GetCurrentOrder(store.Id)
                    .AsWritable(uow);

                if (order.CustomerInfo.CustomerReference == null)
                {
                    var currentMember = Members.GetCurrentMember();
                    if (currentMember is MsParent memberParent)
                    {
                        order.SetProperties(new Dictionary<string, string>
                    {
                        { Constants.Properties.Customer.EmailPropertyAlias, Members.GetCurrentMemberProfileModel().Email },
                        { Constants.Properties.Customer.FirstNamePropertyAlias, memberParent.FirstName },
                        { Constants.Properties.Customer.LastNamePropertyAlias, memberParent.LastName }
                    });
                    }
                    order.AssignToCustomer(currentMember.Key.ToString());
                }

                    var shm = _shippingMethodService.GetShippingMethod(store.Id, "electronic");
                    order.SetShippingMethod(shm);

                    var paymentAlias = "bambora";
                    if (Request.Url.AbsoluteUri.Contains("localhost"))
                    {
                        paymentAlias = "invoicing";
                    }
                    var pm = _paymentMethodService.GetPaymentMethod(store.Id, paymentAlias);
                    order.SetPaymentMethod(pm);


                _orderService.SaveOrder(order);

                uow.Complete();
            }

        }
        catch (Exception ex)
        {
            ModelState.AddModelError("productReference", "Failed to preprocess order");
            Log.Error(ex, "PreprocessOrder exception");

            return CurrentUmbracoPage();
        }

        var checkOutPage = CurrentPage.GetCheckoutPage();

        return RedirectToUmbracoPage(checkOutPage.Id);

    }

But I have another strange behaviour. It looks like my WebApi controller (UmbracoApiController) resets both shippingMethodId and paymentMethodId to null with _orderService.SaveOrder(...)

Hmmmm...

/Tomasz

Aaaah, of course!

Are you using Vendr.Checkout? Or did you just install it for testing? I may need to think about some fine grained control over this then 🤔

Really glad you were able to find the culprit at least.

I think it’s worth leaving this issue open in case someone else has the same problem.

I intended to use Vendr.Checkout in the project. And I had to test Bambora payment.

But the current project can have more simple checkout, so I can just uninstall Vendr.Checkout. But I can imagine that we could use this package in future projects. It may be fine if we just can use it as it is, without shortcuts, as I'm making now :)

/Tomasz

But I'm sure of one thing now: event handlers works pretty good, when registered :)

LOL

/Tomasz

is working on a reply...