Copied to clipboard

Flag this post as spam?

This post will be reported to the moderators as potential spam to be looked at


  • Giampiero D'Agostino 14 posts 106 karma points
    Sep 11, 2020 @ 05:39
    Giampiero D'Agostino
    1

    Price and Tax Class properties disappeared after update to Umbraco 8.7

    Hello, it's me again :)

    This morning I updated a website to Umbraco 8.7 and noticed the following: enter image description here

    The price and Tax Class properties are not rendering anymore. Is that a common issue? Does anybody know what's the easiest way to fix that?

    Cheers,

    Giampiero

  • Matt Brailsford 2807 posts 14331 karma points MVP 7x c-trib
    Sep 11, 2020 @ 08:14
    Matt Brailsford
    1

    Hi Giampiero,

    I'll update the demo store to 8.7 and give this a test, in the meantime though can you check for any javascript errors in the console? And can you also try incrementing your client dependency version number to see if it is a caching issue.

    Matt

  • Matt Brailsford 2807 posts 14331 karma points MVP 7x c-trib
    Sep 11, 2020 @ 08:31
    Matt Brailsford
    1

    Hi Giampiero,

    Ok, I've upgraded the demo store and can replicate this so I'll dig into this and see what I can work out as a fix.

    Thanks for bringing this to my attention. I'll keep you posted.

    Matt

  • Matt Brailsford 2807 posts 14331 karma points MVP 7x c-trib
    Sep 11, 2020 @ 08:41
    Matt Brailsford
    102

    Ok, I've found the bug now so will work on pushing a fix out.

    Ultimately, in 8.7 AngularJS got upgraded and it looks like it now fails if directive use self closing tags, which the price + store entity picker seem to be using to include a file and so because of this it is failing to render the control

    If you want to work around this yourself, you can modify the files in /app_plugins/vendr/views/propertyeditors/price/price.html and /app_plugins/vendr/views/propertyeditors/storeentitypicker/storeentitypicker.html and update the ng-include tags at the top so that they are not self closing (ie, instead of ) this should resolve the issue for you. It should be safe for you to make that change as once I release an update, it will just override those files with the same content.

    Matt

  • Giampiero D'Agostino 14 posts 106 karma points
    Sep 11, 2020 @ 11:35
    Giampiero D'Agostino
    0

    That was quick! Thank you so much Matt! :)

  • Matt Brailsford 2807 posts 14331 karma points MVP 7x c-trib
    Sep 11, 2020 @ 12:21
    Matt Brailsford
    0

    No problem,

    I've found a few more 8.7 quirks along the way so I've sorted those things out too. Just about to push out a new update with them all in.

    I'll post back when it's available.

    Matt

  • Matt Brailsford 2807 posts 14331 karma points MVP 7x c-trib
    Sep 11, 2020 @ 12:45
    Matt Brailsford
    1

    Ok, 1.2.9 is out now with various fixes to make it play nice in Umbraco 8.7

    Thanks for reporting this

    Matt

    UPDATE Annoyingly a style fix I made in my test setup didn't get copied over so I'm gonna be releasing a 1.2.10 in a moment including that fix 🤦‍♂️

    UPDATE 1.2.10 is out now

Please Sign in or register to post replies

Write your reply to:

Draft