Editor user permissions issue with creating discount codes/gift cards
Hi Matt,
My client reported an issue with everytime they log into Umbraco and try to create a discount code or gift card they immediately get logged out of Umbraco and need to close the browser window to gain access again.
I have tested locally and have spotted that if you are an administrator with commerce group access it works fine, but if you are an editor with commerce group access then the issue occurs and you get immediately logged out when trying to create discount codes/gift cards.
I hope it was okay to do this (feel free to delete it afterwards) but I also managed to test this on your demo site as well by creating a user as an editor and the issue also occurs there, the login details if you want to access and try are as follows:
The workaround I have had to give them for now is to provide administrator access but this is not ideal so if you are able to get a fix for this sorted that would be great.
I'll take a look at this as soon as I can. I've raised this as an issue on our issue tracker so I will keep the conversation there but will report back once I have have a resolution / answer https://github.com/vendrhub/vendr/issues/197
Looks like we had the wrong permission checks on the API controllers for both discounts and gift cards. It was checking to make sure you had access to the settings section, but it should have been checking to make sure you had permissions for the commerce section (the controllers probably got copied and pasted from the Vendr settings API controllers and never got updated).
All methods on the controllers have been updated accordingly.
That's perfect, many thanks for sorting so quickly, I look forward to the release of the patch release, do you have any idea for the timeline of when it will be released?
Editor user permissions issue with creating discount codes/gift cards
Hi Matt,
My client reported an issue with everytime they log into Umbraco and try to create a discount code or gift card they immediately get logged out of Umbraco and need to close the browser window to gain access again.
I have tested locally and have spotted that if you are an administrator with commerce group access it works fine, but if you are an editor with commerce group access then the issue occurs and you get immediately logged out when trying to create discount codes/gift cards.
I hope it was okay to do this (feel free to delete it afterwards) but I also managed to test this on your demo site as well by creating a user as an editor and the issue also occurs there, the login details if you want to access and try are as follows:
[email protected]
*iQZTD&WF2
The workaround I have had to give them for now is to provide administrator access but this is not ideal so if you are able to get a fix for this sorted that would be great.
Many thanks,
Graham
Thanks Graham,
I'll take a look at this as soon as I can. I've raised this as an issue on our issue tracker so I will keep the conversation there but will report back once I have have a resolution / answer https://github.com/vendrhub/vendr/issues/197
Matt
Looks like we had the wrong permission checks on the API controllers for both discounts and gift cards. It was checking to make sure you had access to the
settingssection, but it should have been checking to make sure you had permissions for thecommercesection (the controllers probably got copied and pasted from the Vendr settings API controllers and never got updated).All methods on the controllers have been updated accordingly.
Fix will be in 1.3.2 patch release
That's perfect, many thanks for sorting so quickly, I look forward to the release of the patch release, do you have any idea for the timeline of when it will be released?
Hi Graham
I’ll look to get an update out by the end of the week 👍🏻
Matt
Hi Graham.
1.3.2 has just been released containing this fix.
Thanks again for reporting
Matt
Amazing, thanks for sorting so quickly!!
is working on a reply...