Copied to clipboard

Flag this post as spam?

This post will be reported to the moderators as potential spam to be looked at


  • Amir Ahmed 5 posts 85 karma points
    4 days ago
    Amir Ahmed
    0

    Order summary does not expand (mobile view)

    Vendr v1.5.1 Umbraco version 8.11.1

    Summary does not expand when clicked.

    I can fix it by calling initSm(); in the vendrcheckout.js but wondering if this this has been fixed in any subsequent versions or not.

    enter image description here

  • Matt Brailsford 3041 posts 15765 karma points MVP 7x c-trib
    4 days ago
    Matt Brailsford
    0

    Hi Amir,

    I seem to recall this issue previously and am wondering if it's an issue with the simple state machine library not firing on breakpoint change. Are there any JS errors present in developer tools? And are you able to see if the breakpoint code ever runs correctly on breakpoint change?

    Matt

  • Amir Ahmed 5 posts 85 karma points
    4 days ago
    Amir Ahmed
    0

    Hi Matt,

    No console errors

    I just noticed in the vendrcheckout.js that the initCommon() was called but but not the initSm() so I just added that as the fix.

  • Matt Brailsford 3041 posts 15765 karma points MVP 7x c-trib
    4 days ago
    Matt Brailsford
    100

    Hi Amir,

    The call to that method shouldn't really be done manually. The point of the simple state machine library is that it responds to breakpoints and runs the relevant function call when a breakpoint is crossed, so the initSm method should ONLY be run when in a small breakpoint, and then the initLg should be run when you move to/start in the larger breakpoint.

    Maybe upgrading the simple state machine library in the master layout file to a newer version might fix it. This it the library in question https://github.com/jonathan-fielding/SimpleStateManager there appears to be a bunch of newer versions.

    Matt

  • Amir Ahmed 5 posts 85 karma points
    3 days ago
    Amir Ahmed
    0

    That seem to do the trick.. I've upgraded to v4 and it's working fine now. Thanks

  • Matt Brailsford 3041 posts 15765 karma points MVP 7x c-trib
    3 days ago
    Matt Brailsford
    0

    Excellent.

    I'll raise an issue on the Vendr Checkout repo to say we need to upgrade it.

    Glad you were able to get it working though

    Matt

  • Amir Ahmed 5 posts 85 karma points
    4 days ago
    Amir Ahmed
    0

    Ok thanks. I'll give that a try.

Please Sign in or register to post replies

Write your reply to:

Draft