We've recently upgraded our Umbraco instance to 8.14.0 (Vendr 1.3) and when adding a discount Rule the browser window now freezes. There are no console errors, no requests waiting for completion and no errors in the umbraco logs. The only way to get the browser to respond is by refreshing the page. (I'm using chrome 91.0.4472.72, but the client also has this issue on different browsers)
Thinking it was something in our custom installation, I checked by upgrading my demo Umbraco / Vendr setup locally from an earlier working version of umbraco to 8.14.0. The adding of rules to discounts then stopped working again.
Ok, so i've looked into this and it appears to be a bug in Umbraco core.
They seem to have introduced the adding of an "inert" attribute onto the main editor area when you open an dialog, and this should get removed when you close the dialog, but there seems to be a problem when using editorService.closeAll() that it's not removing the inert attribute and so the UI remains unresponsive.
I'm trying to hunt down where this should be happening and why it's not and I'll then report it on the issue tracker, but as this is a core issue, my suggestion right now is to roll back to 8.13 which looks like the version prior to this addition.
My suggestions right now would be to either roll back to 8.13, or, manually apply the fix in the PR which is just a one liner and hope it gets included in 8.15.1
Discount rules not working
We've recently upgraded our Umbraco instance to 8.14.0 (Vendr 1.3) and when adding a discount Rule the browser window now freezes. There are no console errors, no requests waiting for completion and no errors in the umbraco logs. The only way to get the browser to respond is by refreshing the page. (I'm using chrome 91.0.4472.72, but the client also has this issue on different browsers)
Thinking it was something in our custom installation, I checked by upgrading my demo Umbraco / Vendr setup locally from an earlier working version of umbraco to 8.14.0. The adding of rules to discounts then stopped working again.
Hi Ian,
Hmm, without some kind of error I'm not entirely sure what it would be. Best I could guess would maybe be some cached JS?
Do you see any network request during this "freeze"?
Matt
Yeah, it's very strange, I can see no waiting requests in the console / network tab.
I have the clients site running Umbraco 8.14.0 & Vendr 1.83 and my local demo site (vanilla installation) running 8.14.0 & Vendr 1.3.
The issue only started when we upgraded to 8.14.0. I might try a fresh install of 8.14.0 and latest Vendr and see if it still happens.
Hi Matt,
I've just rolled my local instance back to 8.13.1 and the Discount Rule picker started working again. Then re-installed 8.14.0 and its stopped again.
Tested in Chrome and Firefox.
Hi Matt/Ian,
Did you find a reason for the issue above, I am also having the same problem after upgrading from 8.13 to 8.15 with vendr 1.8.3?
Conor
I’ll be taking a look Tomorrow. My guess is something changed in Umbraco that is causing a conflict.
Ok, so i've looked into this and it appears to be a bug in Umbraco core.
They seem to have introduced the adding of an "inert" attribute onto the main editor area when you open an dialog, and this should get removed when you close the dialog, but there seems to be a problem when using
editorService.closeAll()that it's not removing the inert attribute and so the UI remains unresponsive.I'm trying to hunt down where this should be happening and why it's not and I'll then report it on the issue tracker, but as this is a core issue, my suggestion right now is to roll back to 8.13 which looks like the version prior to this addition.
UPDATE:
I've now confirmed this as a core regression and not a Vendr issue. This is due to new changes in core as described above. I've raised an issue on cores issue tracker here https://github.com/umbraco/Umbraco-CMS/issues/10708 and have submitted a PR fix for it here https://github.com/umbraco/Umbraco-CMS/pull/10710
My suggestions right now would be to either roll back to 8.13, or, manually apply the fix in the PR which is just a one liner and hope it gets included in 8.15.1
Here is an example of what you need to change in a general Umbraco project https://github.com/vendrhub/vendr-demo-store/commit/0262081c4b79a388f6ccccfbc4eda44744220151
Thanks Matt, yes we've rolled back to 8.13 for the time being.
I just started looking at an issue on my own Youtube picker package, and it looks like this bug affects that as well.
is working on a reply...