Copied to clipboard

Flag this post as spam?

This post will be reported to the moderators as potential spam to be looked at


  • Rody 80 posts 280 karma points
    Jul 21, 2021 @ 11:18
    Rody
    0

    Custom Order.editor.config

    Hi,

    Since updating to Vendr 1.8.3 our Custom Order Editor Config file is not used any more.

    The changelog confirms something is changed: "Added support for convention based resolution of the order editor config, inline with how analytics and gift cards configs work.", however I am still pointing to a (correct) custom.order.editor.config.js file in the app_plugins directory. And the docs does not say anything about this change. Is there more info available?

    For now, I just overwritten the default order.editor.config.js file and this works, but it is not the intended behavior.

    Rody

  • Matt Brailsford 4125 posts 22224 karma points MVP 9x c-trib
    Jul 21, 2021 @ 11:34
    Matt Brailsford
    0

    Hmm, it definitely should still resolve explicitly defined configs. The convention based stuff is just that it should also be able to look them up via the convention ’storeAlias.order.editor.config.js’

    I’ll take a look this afternoon what could have gone wrong 🤦🏼‍♂️

  • Matt Brailsford 4125 posts 22224 karma points MVP 9x c-trib
    Jul 21, 2021 @ 12:21
    Matt Brailsford
    100

    Doh! Looks like I'm doing

    if(string.IsNullOrWhiteSpace(path))
    

    when I should be doing

    if(!string.IsNullOrWhiteSpace(path))
    

    🤦‍♂️

    Ok, I've pushed a fix to our unstable feed https://nuget.outfield.digital/unstable/vendr/v3/index.json it'll be the latest 1.8.4-beta003.

    If you wanna test it, I'll get that pushed out with some other 1.8.4 fixes ready to go out.

  • Fedor Krutko 13 posts 123 karma points
    Jul 22, 2021 @ 11:23
    Fedor Krutko
    0

    Hi Matt,

    sorry, but I have the same issue, even after updating to v1.8.4.

  • Matt Brailsford 4125 posts 22224 karma points MVP 9x c-trib
    Jul 22, 2021 @ 12:25
    Matt Brailsford
    0

    Really? Dang!

    I've gone and re implemented how the files are looked up to see if this fixes it. There should be a 1.8.5-beta001 on the unstable nuget feed soon if you want to try that https://nuget.outfield.digital/unstable/vendr/v3/index.json

    Do let me know if that fixes it for you.

    Matt

  • Fedor Krutko 13 posts 123 karma points
    Jul 22, 2021 @ 14:14
    Fedor Krutko
    0

    This did help indeed! Took me a minute to find the new version though, as there was no 1.8.5-beta001, only 1.8.4-beta006

    Nevertheless, it works fine now, thanks!

  • Matt Brailsford 4125 posts 22224 karma points MVP 9x c-trib
    Jul 23, 2021 @ 08:16
    Matt Brailsford
    0

    Haha, opps, looks like I didn't create a 1.8.5 hotfix branch 🤦‍♂️ That was the right build though. I'll get that pushed out today.

    Thanks for testing

    Matt

  • This forum is in read-only mode while we transition to the new forum.

    You can continue this topic on the new forum by tapping the "Continue discussion" link below.

Please Sign in or register to post replies