Sure, you could do that.

So when your user logs in / out you'll want to call the following with the relevant tax class IDs

_vendrApi.SetDefaultTaxClass(taxClassId, applyToCurrentOrder:true);

This will set the sessions default tax class to be whatever you determine it to be and thus whenever a new order is created in that session, it should take that tax class. By passing applyToCurrentOrder:true you are also saying to apply that to any open orders for this current session too.

Matt,

Interestingly enough the .04 cents comes into pla when moving from Customer Information to the Payment Method in Vendr Checkout.

This leads me to believe it may be the payment provider cost, however all of my payment providers are explicitly set to zero.

See the correct price on the customer info below:

Then i move to payment-method and see the .04 cent difference:

Im looking into what happens between the steps but until i find something i figured i would pick your brain

Matt,

See my above note. I have looked an dug around but cannot find where a random .04 cents would be added if I have a zeroed tax class for each region?

Thanks

Hey Kyle,

I'm not exactly sure where it's coming from. I've just tried in the demo store setting the tax rate to zero and then adding items to the cart / going through the checkout with shipping / payment method being zero value and everything is adding up correctly.

Do you have anything else in place that could be affecting this?

Hi Kyle,

Sure, but I'm doing the exact same thing and getting a correct result so something else is a foot. I really need to be able to replicate it to debug it.

Hey Kyle,

It is yea, and it's what we do on Vendr too when someone provides a VAT number in Europe which means we don't charge tax, so it should all be working.

Matt,

Can you elaborate the process of what GetCurrentOrder() does? It seems that when getting the current order, I am calculating taxes, what would the injection point be for when an order is started and tax is calculated, I need to check is a member is logged in and if so check a status on my end to determine if they are tax exempt...

Hey Kyle

GetCurrentOrder simply looks for an order ID in a the Vendr cookie and if one exists, calls orderService.GetOrder(id) for it which will either get the order from the DB if one isn't in cache, or just retrieve it from the cache.

GetCurrentOrder shouldn't be doing anything to modify the order.

Makes sense as it returns a read only order, so with that in mind it also shouldn't do any calculations on the order as well, which then means I am not zeroing out the tax properly somewhere....

When does OrderCalculation pickup the order?

Ideally, I need to check a property at the time when the OrderCalculation Object picks up the order.

My reasoning is this: when the OrderCalculation object picks up an order, if I check whether I have a member logged in or not i could then further check if they are tax exempt, if they are, assign a taxClassId to the order instead of the default one for the region they are in.

As the OrderCalculation object always holds the absolute most up to date Order

I hope this makes sense.

So for example, I have a customer logged in and they add something to their cart, right now I show a taxRate of 6%, when in reality, i know they are tax exempt because I set them this way, I would expect a taxRate of 0.00%

Matt,

When I move from Customer information checkout step to the next step, looking at the current order context I see the following

context.order has a 0% taxRate

but

context.OrderCalculation has a 6% taxRate.

Do you always use the order calculation instead of the order to get the most up to date order there is?

Hey Kyle,

What are you currently overriding such that you have an OrderCalculation context?

OrderCalculation is created during a re-calculation of an order and whatever is in the context is what will get applied to the order at the end once the calculation is complete.

Generally speaking though, calling SetTaxClass() on the order should require that the order is re-calculated when any price property is accessed.

Matt

I am overriding the CalculateShippungMEthodPrice with the code below. You can see I check OrderCalculation, Ive done that as this method is called via an AJAX call and when updating via ajax i found that the shippping cost would be one call behind when using just the order context.

I debuged it and found orderCalcultion held the correct values for me.

Certainly I could debug this further if something isnt quite right

Not sure if this is right or wrong.

public override Price CalculateShippingMethodPrice(ShippingMethodReadOnly shippingMethod, Guid currencyId, Guid? countryId, Guid? regionId, TaxRate taxRate, ShippingCalculatorContext context)
        {
            var shippingPrice = new Decimal();

            var allLineItemsPrice = new Decimal();
            if (context.OrderCalculation != null)
            {
                foreach (var lineItem in context.OrderCalculation.OrderLines)
                {
                    allLineItemsPrice += lineItem.Value.TotalPrice.Value.WithoutTax;
                }
            }
            else
            {
                foreach (var lineItem in context.Order.OrderLines)
                {
                    allLineItemsPrice += lineItem.TotalPrice.Value.WithoutTax;
                }
            }

            shippingPrice = SMMoyerFireEcommerce.Core.Extensions.PublishedContentExtensions.CalculateShippingCostForOrder(allLineItemsPrice);

            if (context.Order.Discounts.Any())
            {
                var discounts = VendrApi.Instance.GetActiveDiscounts(context.Order.StoreId);
                foreach (var discount in discounts)
                {
                    if (discount.Name == "Free Shipping")
                    {
                        shippingPrice = 0;
                    }
                }

            }


            var price = new Price(shippingPrice, taxRate, currencyId);

            //var shippingPrice = _shippingService.GetShippingPrice(context.Order, currencyId);

            if (price == null)
            {
                price = base.CalculateShippingMethodPrice(shippingMethod, currencyId, countryId, regionId, taxRate, context);
            }

            return price;
        }

Hey Kyle,

Ok, yea. If there is an OrderCalculation then you should use it as yes, this will be the most up to date for that given execution (you can read more about this here https://vendr.net/docs/core/2.1.0/umbraco-v9/key-concepts/order-calculation-state/)

So the only thing I can potentially see wrong here is that during a calculation process things work in cycles, first working out the un-discounted price and then working out discounts and then the final totals. Shipping calculators will run in the first wave calculating the un-discounted price but this means accessing the TotalPrice.Value of anything is likely un-set as the actual totals haven't been calculated yet. So you would need to access the TotalPrice.WithoutAdjustments property value instead (I have a fix for this coming in the next patch release as this also confused someone else so I'm now setting all prices temporarily and then just overriding them when I have the discounted version)

I'm not exactly sure if this is your issue though. Are you saying this code work and you no-longer have an issue? or this code works but you are still seeing the .04 cent bad calculation?

Matt,

With the code as it sits I see the bad $0.04 issue.

So you are saying access the TotalPrice.WithoutAdjustments for my proper tax calculation?

The only other thing I notice is that the TaxRate parameter in that method when run comes in one time with 0% and then a second time with 6%, I imagine these are the cycles your talking about during calculation

Hey Kyle,

For the time you have an OrderCalculation yes you should use WithoutAdjustments if you just have an order, you can use whatever makes sense.

RE cycles, the calculator should only be executed once per calculation so if it's coming around twice, then the order must be being re-calculated multiple times.

What is the code you are using for setting the tax rate?

Matt,

When a user logs into their account, I check if their tax status is true/false (true = tax exempt, false = not).

With that in mind I run this code:

                   if(member.ContentType.Name == "Business")
                    {
                        //check to see if the user thats logged in is tax exempt or not
                        if (Convert.ToBoolean(member.Properties["taxExemptionStatus"].GetValue()))
                        {
                            var taxExemptTaxClass = _vendrApi.GetTaxClass(_storeService.GetStore("sMMoyerFireEquipment").Id, "taxExemptCustomers");
                            _vendrApi.SetDefaultTaxClass(_storeService.GetStore("sMMoyerFireEquipment").Id, taxExemptTaxClass.Id, true);
                        }
                    } 

This may be irrelevant but when a customer adds something to their cart, I also call this code, which to my knowledge will also cause a calculation when using SaveOrder()

order.SetShippingMethod(_sessionManager.GetDefaultShippingMethod(store.Id));
order.SetShippingCountryRegion(_sessionManager.GetDefaultShippingCountry(store.Id));

_orderService.SaveOrder(order);

I run this code in my AddToCart Method in order to set the proper shipping method and region for calculating shipping cost for the order as the shipping cost is just a percentage on the sub total, which I show in the cart. This is where I would be using the OrderCalculation context as well as this AddToCart method is called with AJAX

This could be where the additional calcs are coming in but Im not 100% sure.

Hmm, I can't really see anything that would be a problem here. Maybe just make sure you fetch the order after you have set the default tax class as that will apply the tax rate in the background but it won't update any existing instances of the order you have.

But I can't really see anything here that would relate to the .04 cent issue 🤔