Hello!
I just tried playing around with the discounts and added a discount code in the Vendr Commerce. Everything works fine in the checkout, I can add the code and see my discount. However, when I try to take away the discount again with the black X I get an error page (see picture).
If I reverse to the last page again it works fine, the discount is no longer there and I can continue with my payment. I do not believe the customers who get this error page will understand that though....
Is this a bug or something we can fix on our side?
I see what the issue is here and I'll get a patch release out this week (I need to make a Vendr Checkout update anyway).
It looks like out method for checking if the request is an ajax requests attempts to check for a field in the forms collection without first checking if the request is actually a POST request (which throws an error in .NET Core where it didn't in .NET Framework).
No, it's just a change to the CartSufaceController that when checking to see if the request is an ajax request, it doesn't read Request.Form without first checking the request is a POST request.
This should have been fixed in 2.1.1 which is released yes. I just realized yesterday though that I haven't released a Vendr Checkout v3 for Vendr v3 yet so I'll get that released shortly.
The v3 release is on the unstable feed right now if you want to test it and make sure it works as I think it's just the testing side of things I need to complete.
Can't remove discount code from checkout
Hello! I just tried playing around with the discounts and added a discount code in the Vendr Commerce. Everything works fine in the checkout, I can add the code and see my discount. However, when I try to take away the discount again with the black X I get an error page (see picture).
If I reverse to the last page again it works fine, the discount is no longer there and I can continue with my payment. I do not believe the customers who get this error page will understand that though....
Is this a bug or something we can fix on our side?
Kind regards Michelle
Hi Michelle,
I see what the issue is here and I'll get a patch release out this week (I need to make a Vendr Checkout update anyway).
It looks like out method for checking if the request is an ajax requests attempts to check for a field in the forms collection without first checking if the request is actually a POST request (which throws an error in .NET Core where it didn't in .NET Framework).
I'll get that updated and a new release out soon.
Matt
Hey Michelle,
If you want to test this, I have a 2.1.1-beta0001 build on our unstable nuget feed at https://nuget.outfield.digital/unstable/vendr/v3/index.json
If you can confirm this resolves the issue for you that would be great.
Many thanks
Matt
Hello again and thank you for that quick answer! With this fix, will there be any changes to the view or css?
Kind regards, Michelle
Hi Michelle,
No, it's just a change to the
CartSufaceControllerthat when checking to see if the request is an ajax request, it doesn't readRequest.Formwithout first checking the request is a POST request.Matt
Hello Matt!
Is this fixed in a newer version that is not on unstable nudget feed?
Kind regards Michelle
Hi Michelle,
This should have been fixed in 2.1.1 which is released yes. I just realized yesterday though that I haven't released a Vendr Checkout v3 for Vendr v3 yet so I'll get that released shortly.
The v3 release is on the unstable feed right now if you want to test it and make sure it works as I think it's just the testing side of things I need to complete.
is working on a reply...