Copied to clipboard

Flag this post as spam?

This post will be reported to the moderators as potential spam to be looked at


  • Søren Tidmand 113 posts 296 karma points
    16 days ago
    Søren Tidmand
    0

    Is "icon" a reserved alias in Stacked Content?

    Hi, I've encountered a weird issue when using "icon" as a property alias on a doctype used inside Stacked Content. The property doesn't save ... but after renaming the property alias everything works. Does anybody know whether "icon" is a reserved property alias name in Stacked Content? /Søren

  • Lee Kelleher 3774 posts 13946 karma points MVP 8x admin c-trib
    16 days ago
    Lee Kelleher
    100

    Hi Søren,

    Yeah, "icon" is a reserved alias... along with "name", "children" and "key".

    https://github.com/umco/umbraco-inner-content/blob/1.1.1/src/Our.Umbraco.InnerContent/PropertyEditors/InnerContentPropertyValueEditorWrapper.cs#L235-L243

    I can't recall why we had it as a reserved alias, I'm sure there was a reason at the time, hmmm.

    - Lee

  • Søren Tidmand 113 posts 296 karma points
    16 days ago
    Søren Tidmand
    0

    Thanks Lee for the quick response.

    /Søren

  • Jesper Ordrup 957 posts 1321 karma points MVP
    16 days ago
    Jesper Ordrup
    0

    Thanks Lee and Søren.

    The reserved aliases are they described anywhere in the docs (cant find it)? The list in the wrapper shows some very common named aliases which are likely to be used in doctypes.

    This one was a bastard to find ...

    :-) Jesper

  • Lee Kelleher 3774 posts 13946 karma points MVP 8x admin c-trib
    16 days ago
    Lee Kelleher
    0

    Hi Jesper,

    There aren't any docs for Stacked Content yet (well, Inner Content - the helper library part) ... I appreciate this would have been a bugger to figure out, sorry.

    Umbraco does already reserve "name" and "children" as property aliases - they'll throw an error in the doctype editor.

    Like I said to Søren, I can't recall why we reserved "icon" and "key" ... although I'd have thought "key" would be reserved as it's used by IPublishedContent.

    If I was dev'ing it again now, I'd have probably prefixed "icon" with something else.

    Cheers,
    - Lee

  • Lee Kelleher 3774 posts 13946 karma points MVP 8x admin c-trib
    16 days ago
    Lee Kelleher
    0

    I've raised a ticket on our issue tracker: https://github.com/umco/umbraco-inner-content/issues/31

  • Jesper Ordrup 957 posts 1321 karma points MVP
    16 days ago
    Jesper Ordrup
    0

    Hi Lee,

    Thanks for raising a ticket. The other aliases we prob wouldn't dare trying anyway.

    Thanks again and have a great summer.

    All the best -Jesper

Please Sign in or register to post replies

Write your reply to:

Draft