Hi Anders,

Currently I am trying to get the current page via the macro and pass it to the service class, I did create another thread explaining that - https://our.umbraco.com/forum/using-umbraco-and-getting-started/102172-get-current-page-via-a-macro and it was later discovered that DI was not set up properly for UmbracoHelper

I'm generally wrapping up the UmbracoHelper class to minimise numerous direct calls to Umbraco. Currently I have the following in the custom wrapper class:

public class UmbracoHelperWrapper : IUmbracoHelper
{
    private readonly UmbracoHelper _umbracoHelper;

    public UmbracoHelperWrapper(UmbracoHelper umbracoHelper)
    {
        _umbracoHelper = umbracoHelper ?? throw new ArgumentNullException(nameof(umbracoHelper));
    }

    public IPublishedContent GetCurrentPage()
    {
        return _umbracoHelper.AssignedContentItem;
    }

    public IPublishedContent TypedContent(Guid id)
    {
        return _umbracoHelper.Content(id);
    }

    public IPublishedContent TypedContentSingleAtXPath(string path)
    {
        return _umbracoHelper.ContentSingleAtXPath(path);
    }

    public IEnumerable<IPublishedContent> TypedContentAtXPath(string path)
    {
        return _umbracoHelper.ContentAtXPath(path);
    }
}

And I registered this class in V8 as:

composition.Register<IUmbracoHelper, UmbracoHelperWrapper>();

However, UmbracoHelper is not populated. In V7 it was done in in DI as:

builder.Register(x => new UmbracoHelperWrapper(new UmbracoHelper(UmbracoContext.Current))).As<IUmbracoHelper>().InstancePerRequest();

The builder is of the ContainerBuilder type, which is part of AutoFac, but given V8 is DI out of the box, I don't think its no longer necessary to use that.

Hi Marc,

I don't believe it's possible to get the current page (AssignedContentItem) via the IUmbracoContextFactory? As that seems to be part of the UmbracoHelper.

I have done the following, is that what you want meant:

composition.Register<IUmbracoHelper, UmbracoHelperWrapper>(Lifetime.Request);

However, I don't think this is correctly registered

UmbracoContext gives you access to the current Umbraco request, so you should be able to access the current page via:

factory.EnsureUmbracoContext().UmbracoContext.PublishedRequest.PublishedContent

You may need to add some null checks along the way, but otherwise it should do the trick ;)

Thanks Anders! However, I am getting a null.

To give more context, I am trying to get the current page whenever a macro is being used on a page. i.e. If there is an About page, the macro will then be called and then the About page would be returned, irregardless whether the page is published or not. And, in V7, I found that the surefire way was to use the UmbracoHelper.

Again, thanks for your help! It's much appreciated!

Ironically, I can get the HttpContext, and that does return the macro, but whenever trying to get current page via the above, it provides a null.

Of course, you can use GetById, but that is not what I want to do, as I want to get the page dynamically.

Hi Anders,

Yes, the macro is inheriting the PartialViewMacroPage and I initially was using the Model from within this razor and then passing that as a parameter to get the current page, which does work for both published/unpublished instances.

However, I am lead to believe this may be bad practice to pass models when trying to get the current page dynamically. However, this raises questions as to why the factory would be null?