we get an error during a sendout (umbraco 7.2.2, newsletterstudio 2.1). The Sendout worked for 4000 of 12000 subscribers and stopped with the following error:
NewsletterStudio, SendNewsletterService: There is already an open DataReader associated with this Command which must be closed first. : at System.Data.SqlClient.SqlInternalConnectionTds.ValidateConnectionForExecute(SqlCommand command)
at System.Data.SqlClient.SqlCommand.ValidateCommand(String method, Boolean async)
at System.Data.SqlClient.SqlCommand.InternalExecuteNonQuery(TaskCompletionSource`1 completion, String methodName, Boolean sendToPipe, Int32 timeout, Boolean asyncWrite)
at System.Data.SqlClient.SqlCommand.ExecuteNonQuery()
at System.Data.SqlClient.SqlCommand.ExecuteNonQuery()
at NewsletterStudio.Infrastucture.Data.PetaPoco.Database.Execute(String sql, Object[] args)
at NewsletterStudio.Infrastucture.Data.PPDatabaseAdaptor.Execute(String sql, Object[] parameters)
at NewsletterStudio.Infrastucture.Data.SubscriberRepository.SetAsActive(Int32[] ids)
at NewsletterStudio.Services.SendNewsletterService.SendEmails()
looking in the logfiles i find 2 other exceptions:
2015-03-26 16:12:06,584 [12] INFO umbraco.BusinessLogic.Log -Sen [Thread 31] Redirected log call (please use Umbraco.Core.Logging.LogHelper instead of umbraco.BusinessLogic.Log) | Type: Error | User: 0 | NodeId: 0 | Comment: NewsletterStudio, SendNewsletterService: There is already an open DataReader associated with this Command which must be closed first. : at System.Data.SqlClient.SqlInternalConnectionTds.ValidateConnectionForExecute(SqlCommand command)
at System.Data.SqlClient.SqlCommand.ValidateCommand(String method, Boolean async)
at System.Data.SqlClient.SqlCommand.InternalExecuteNonQuery(TaskCompletionSource`1 completion, String methodName, Boolean sendToPipe, Int32 timeout, Boolean asyncWrite)
at System.Data.SqlClient.SqlCommand.ExecuteNonQuery()
at System.Data.SqlClient.SqlCommand.ExecuteNonQuery()
at NewsletterStudio.Infrastucture.Data.PetaPoco.Database.Execute(String sql, Object[] args)
at NewsletterStudio.Infrastucture.Data.PPDatabaseAdaptor.Execute(String sql, Object[] parameters)
at NewsletterStudio.Infrastucture.Data.SubscriberRepository.SetAsActive(Int32[] ids)
at NewsletterStudio.Services.SendNewsletterService.SendEmails()
and
2015-03-26 16:13:47,349 [12] ERROR Umbraco.Core.UmbracoApplicationBase - [Thread 9] An unhandled exception occurred
System.Web.HttpUnhandledException (0x80004005): Exception of type 'System.Web.HttpUnhandledException' was thrown. ---> System.ArgumentException: Can't track click without e-mail (e)
at NewsletterStudio.App_Plugins.NewsletterStudio.Pages.Tracking.TrackPixel.ProccessQueryString()
at NewsletterStudio.App_Plugins.NewsletterStudio.Pages.Tracking.TrackPixel.Page_Load(Object sender, EventArgs e)
at System.Web.UI.Control.LoadRecursive()
at System.Web.UI.Page.ProcessRequestMain(Boolean includeStagesBeforeAsyncPoint, Boolean includeStagesAfterAsyncPoint)
at System.Web.UI.Page.HandleError(Exception e)
at System.Web.UI.Page.ProcessRequestMain(Boolean includeStagesBeforeAsyncPoint, Boolean includeStagesAfterAsyncPoint)
at System.Web.UI.Page.ProcessRequest(Boolean includeStagesBeforeAsyncPoint, Boolean includeStagesAfterAsyncPoint)
at System.Web.UI.Page.ProcessRequest(Boolean includeStagesBeforeAsyncPoint, Boolean includeStagesAfterAsyncPoint)
at System.Web.UI.Page.ProcessRequest()
at System.Web.UI.Page.ProcessRequest(HttpContext context)
at System.Web.HttpApplication.CallHandlerExecutionStep.System.Web.HttpApplication.IExecutionStep.Execute()
at System.Web.HttpApplication.CallHandlerExecutionStep.System.Web.HttpApplication.IExecutionStep.Execute()
at System.Web.HttpApplication.ExecuteStep(IExecutionStep step, Boolean& completedSynchronously)
in the past, the sendout worked fine without any troubles.
this error occured for the first time. in the past we sent out about 4 newsletter the last weeks without any troubles or errors.
maybe an important information: we trigger the sendout from the "Newsletter Send Out Properity Editor" in the Content Section. when i click there on "restart", a save event is triggered and the error still exists.
when i click on "restart the sendout" in the newsletter studio section, the send out continues now and is delivering mails. my problem is, that the content editors don't have any access to the newsletter studio section in the backend. clicking on "continue" in the property editor in the content section does nothing.
if i can assist in helping to get more information about this errors, just let me know.
"when i click on "restart the sendout" in the newsletter studio section, the send out continues now and is delivering mails. my problem is, that the content editors don't have any access to the newsletter studio section in the backend. clicking on "continue" in the property editor in the content section does nothing."
But you're saying that it works as expected in the Newsletter Studio-section?
I will add a bug report to the backlog and we'll look closer at this in the futher development - I'll keep you posted.
I would like to add that I have observed the same issue ("There is already an open DataReader") on a different host, which we upgraded to the latest version of Newsletter studio already to improve stability.
Thank you for letting me know. we have confirmed some potential issues with how the petapoco-version that we are using handles connections under load and this might be the reson. If you would like to test our patch-version just drop me an email at markus [at sign goes here] enkelmedia.se.
actually we hat lots auf umbraco application shutdowns that made a normal newsletter sendout impossible (problem was a faulty microsoft update, more info here).
we did apply the patch you sent to Peter, and it looks good at the moment. we will keep an eye on it!
SendNewsletterService Error
Hi,
we get an error during a sendout (umbraco 7.2.2, newsletterstudio 2.1). The Sendout worked for 4000 of 12000 subscribers and stopped with the following error:
looking in the logfiles i find 2 other exceptions:
and
in the past, the sendout worked fine without any troubles.
looking forward to your help!
thx in advance,
Andreas
Hi!
Thank you very for using the package!
Does this happen all the time or this just a "one time error"? What happens if you restart the send out again? Same error?
Did you upgrade or change something or did this error just show up in your current set up.
I'll have a look at the code to see if there is something I can find about it...
// m
Hi,
this error occured for the first time. in the past we sent out about 4 newsletter the last weeks without any troubles or errors.
maybe an important information: we trigger the sendout from the "Newsletter Send Out Properity Editor" in the Content Section. when i click there on "restart", a save event is triggered and the error still exists.
when i click on "restart the sendout" in the newsletter studio section, the send out continues now and is delivering mails. my problem is, that the content editors don't have any access to the newsletter studio section in the backend. clicking on "continue" in the property editor in the content section does nothing.
if i can assist in helping to get more information about this errors, just let me know.
thx,
Andreas
Hi!
I have to look closer at this:
"when i click on "restart the sendout" in the newsletter studio section, the send out continues now and is delivering mails. my problem is, that the content editors don't have any access to the newsletter studio section in the backend. clicking on "continue" in the property editor in the content section does nothing."
But you're saying that it works as expected in the Newsletter Studio-section?
I will add a bug report to the backlog and we'll look closer at this in the futher development - I'll keep you posted.
I would like to add that I have observed the same issue ("There is already an open DataReader") on a different host, which we upgraded to the latest version of Newsletter studio already to improve stability.
Regards, Peter.
Hi Peter!
Thank you for letting me know. we have confirmed some potential issues with how the petapoco-version that we are using handles connections under load and this might be the reson. If you would like to test our patch-version just drop me an email at markus [at sign goes here] enkelmedia.se.
Cheers
// m
Hi Markus,
actually we hat lots auf umbraco application shutdowns that made a normal newsletter sendout impossible (problem was a faulty microsoft update, more info here).
we did apply the patch you sent to Peter, and it looks good at the moment. we will keep an eye on it!
cheers,
Andreas
Hi!
Thank you great! =D Just keep me posted it you have futher issues!
/ m
is working on a reply...