plumber - v1.1.12-build402 - 2020-01-24

Umbraco 7.15.3

Been having a couple issues with the workflow.js file.

1. In the workflow dashboard, highcharts is not displaying items created that day.

Looks like the issue is in \www\App_Plugins\Workflow\backoffice\js\workflow.js line 108

 s.data[_this.range - now.diff(moment(v.completedDate), 'days')] += 1
 created.data[_this.range - now.diff(moment(v.createdDate), 'days')] += 1;

The size of s.data and created.data are equal to the selected date range. If v.completedDate or v.createdDate are today's date, the now.diff in days will be zero. Because of zero-indexing, these lines then try and add 1 to a non-existent item that is one beyond the last item in the array. The array then adds an extra item with NaN as the value. This causes the highchart graph to display no values. Simply subtracting 1 from the index allows the chart to be displayed but causes issues with displaying the correct dates.

2) The dashboard gets an error if you select 'instance' from the 'view type' dropdown. This is because http://dev.www.opm.gov/umbraco/backoffice/api/workflow/instancesrange/1 gets a 404 error. Looks like the url constructor is not adding a slack after instances, as http://dev.www.opm.gov/umbraco/backoffice/api/workflow/instances/range/1 returns results.

getAllInstancesForRange: function getAllInstancesForRange(days) {
        return request('GET', urls.instances + 'range/' + days);
      },