Hi, I'm testing Plumber 1.1.3 with Umbraco 8.6.0 for the first time.
I'm experiencing some issues, maybe some of them are errors in Plumber, but I guess some of them are just my missing understanding of Plumber :-)
I know it's not best practice to ask multiple questions in one thread, but, sorry.
1) Our customer want's to be able to add workflow to specific pages, not entire branches of the tree. They can do that by adding approval groups directly on the node in the content tree, but the problem (in our case) is that this is inherited to all sub pages asweel. Is it possible to change so that approval groups on nodes is not inherited to sub pages by default?
2) Since the customer only want's to activate workflow on some page we keep getting the "Workflow not configured" dialog for our root nodes, when viewing the Workflow dashboard in the Content section. We should either add an explicit workflow or exlude the node from workflow, but that's not what we want in our case. Can we disable the dialog somehow?
3) When adding or removing approval groups directly on content node you need to click the save button in order to save the changes.
However when removing the last approval group from a content node, the save button disappears so that you can't save the changes, meaning that you can't disable workflows on a node. Is this an error?
4) In our test case we only have one apporval group. The accept (and cancel) works fine, but we have some problems with the reject flow.
An editor not in the approval group updates a page, saves the page
and clicks "Request publish"
An editor in the approval group rejects the changes
The original editor updates the page again, saves the page, but
can't resubmit the page. I'm I doing something wrong or missing
something?
5) The editor not in the approval group has the Umbraco publish rights, but can't publish pages with workflows, this make sense, but the editor can still select "Schedule..." and "Publish with descendants..." is this right?
Inheriting config is the the default behaviour, but it's possible to override using the Exclude nodes setting (requires a paid subscription/license).
Given the config inheritance, root nodes need to have a workflow configured. I'll have a look at what happens if that requirement is removed - ie, what happens when a node has no ancestor with workflow config. The dialog, at the moment, can not be disabled.
This is fixed in the next release
This is also fixed in the next release. I hadn't been able to reproduce the issue, until I realised it only happens when the editor does not have publish permissions. Will be in a nightly soon.
Also fixed - workflow admin users (ie those with access to the workflow backoffice section) will always have access to their default Umbraco options, in addition to the workflow buttons. Means that administrators don't have to use the workflow for all publish/unpublish/schedule activity.
I'm close to finishing a full es6 rewrite of the backoffice, and new build process, so understandably a lot of changes in the next release. I don't have a release date, but should be in the next week or two.
We finally come the phase in the project where we will be implementing Plumber.
We have just installed the lastest version, 1.3.4, and I can see that lots of the issues we faced in version 1.1.3 has been fixed, thanks.
Publishing
For now we are only facing one "critial" error.
We have created a new user with the default editor role and the user is not the the single appoval group we have. On pages with workflows the editor is still able to select the "Publish with descentants..." and from there bypass the workflow.
Tranlations
Another minor thing is that the customer want the interface in danish, so we have have just created a copy of the language file, adjusted it to danish and
translated the labels. However not all labels are defined in the language file but just written directly in the view/js files.
Licensing
We see that the licensing has changed in version 1.3.4 to only have one type of licens, one-off licens (besides free). We like that, but we cant find much information about whats included in the new licens.
Is the licens bound to a single domain, including subdomains, as the old licenses or is is just one licens pr umbraco installation? We plan to have a multisite Umbraco installation on multiple servers, but will only serve the Umbraco backoffice from one domain.
We properbly need more than 5 approval groups and more than five users in each group. From what we found in the documentation, the paid licens removes the restriction on the number of approval groups, but does not mention anything about the restriction for the number of users in each approval group.
I've just pushed a fix for the publish-with-descendants button, I'll include that in 1.3.5 (thanks for flagging it, I hadn't noticed previously).
I'm working through making everything localizable - the latest 1.3.5 betas will be a lot more complete than 1.3.4, but there's still a few places to do. Some are simple enough, others take a bit more thought and need more changes. If you were happy to share, I'd love to include the Danish language file in the package - localization is hard in that I can make it work, but won't have the translations available.
As for licensing, I'm in the midst of building a semi-decent brochure site with all the detail. New model is much simpler - no subscriptions, just a single price-point to enable all features and remove all limits (groups and group membership included). License is tied to the backoffice instance, and validated against the domain serving Umbraco, so if you're hosting 100 sites in a single Umbraco instance, all sites will fall under the same license.
To be honest, the package wasn't built with multi-site in mind, so some features may not work correctly. Might need to add that to the todo list and verify some bits...
Sounds great with fix for the publish-with-descendants and the info about the licens.
For the localization we still need to translate some of the labels, but when this is done we will be happy to share the danish translation file with you. We can also include the extra labels you add in version 1.3.5.
Well spotted - I thought I'd got em all. Thought wrong. I'll fix those tomorrow morning and release a patch, but if you could send the Danish XML to nathan at nathanw dot com dot au I'll include it too, which will be awesome, thank you!
Unable to resubmit node after rejection
Hi, I'm testing Plumber 1.1.3 with Umbraco 8.6.0 for the first time.
I'm experiencing some issues, maybe some of them are errors in Plumber, but I guess some of them are just my missing understanding of Plumber :-)
I know it's not best practice to ask multiple questions in one thread, but, sorry.
1) Our customer want's to be able to add workflow to specific pages, not entire branches of the tree. They can do that by adding approval groups directly on the node in the content tree, but the problem (in our case) is that this is inherited to all sub pages asweel. Is it possible to change so that approval groups on nodes is not inherited to sub pages by default?
2) Since the customer only want's to activate workflow on some page we keep getting the "Workflow not configured" dialog for our root nodes, when viewing the Workflow dashboard in the Content section. We should either add an explicit workflow or exlude the node from workflow, but that's not what we want in our case. Can we disable the dialog somehow?
3) When adding or removing approval groups directly on content node you need to click the save button in order to save the changes.
However when removing the last approval group from a content node, the save button disappears so that you can't save the changes, meaning that you can't disable workflows on a node. Is this an error?
4) In our test case we only have one apporval group. The accept (and cancel) works fine, but we have some problems with the reject flow.
5) The editor not in the approval group has the Umbraco publish rights, but can't publish pages with workflows, this make sense, but the editor can still select "Schedule..." and "Publish with descendants..." is this right?
Thanks
Hi Jesper
Will address these as best I can...
I'm close to finishing a full es6 rewrite of the backoffice, and new build process, so understandably a lot of changes in the next release. I don't have a release date, but should be in the next week or two.
Hi Nathan,
Thank you so much for fast repsonse and for answering all my issues/questions.
I'm looking forward to test the next release.
There's a new nightly on nuget now (v1.2.0 beta). To be honest, I haven't installed it or done any real testing other than while working on changes 😁
I'll try to find time over the weekend to spin it up and double check stuff...
Hi Nathan,
We finally come the phase in the project where we will be implementing Plumber.
We have just installed the lastest version, 1.3.4, and I can see that lots of the issues we faced in version 1.1.3 has been fixed, thanks.
Publishing
For now we are only facing one "critial" error.
We have created a new user with the default editor role and the user is not the the single appoval group we have. On pages with workflows the editor is still able to select the "Publish with descentants..." and from there bypass the workflow.
Tranlations
Another minor thing is that the customer want the interface in danish, so we have have just created a copy of the language file, adjusted it to danish and translated the labels. However not all labels are defined in the language file but just written directly in the view/js files.
Licensing
We see that the licensing has changed in version 1.3.4 to only have one type of licens, one-off licens (besides free). We like that, but we cant find much information about whats included in the new licens.
Is the licens bound to a single domain, including subdomains, as the old licenses or is is just one licens pr umbraco installation? We plan to have a multisite Umbraco installation on multiple servers, but will only serve the Umbraco backoffice from one domain.
We properbly need more than 5 approval groups and more than five users in each group. From what we found in the documentation, the paid licens removes the restriction on the number of approval groups, but does not mention anything about the restriction for the number of users in each approval group.
Hi Jesper
I've just pushed a fix for the publish-with-descendants button, I'll include that in 1.3.5 (thanks for flagging it, I hadn't noticed previously).
I'm working through making everything localizable - the latest 1.3.5 betas will be a lot more complete than 1.3.4, but there's still a few places to do. Some are simple enough, others take a bit more thought and need more changes. If you were happy to share, I'd love to include the Danish language file in the package - localization is hard in that I can make it work, but won't have the translations available.
As for licensing, I'm in the midst of building a semi-decent brochure site with all the detail. New model is much simpler - no subscriptions, just a single price-point to enable all features and remove all limits (groups and group membership included). License is tied to the backoffice instance, and validated against the domain serving Umbraco, so if you're hosting 100 sites in a single Umbraco instance, all sites will fall under the same license.
To be honest, the package wasn't built with multi-site in mind, so some features may not work correctly. Might need to add that to the todo list and verify some bits...
Hi Nathan,
Sounds great with fix for the publish-with-descendants and the info about the licens.
For the localization we still need to translate some of the labels, but when this is done we will be happy to share the danish translation file with you. We can also include the extra labels you add in version 1.3.5.
That would be awesome! Thank you!
1.3.5 is out now, spent a chunk of time today working through more localization, I think I've caught everything.
Hi Nathan,
I have installed 1.3.5 and translated the new labels into danish. How can I send you the danish language file? I can only upload images here.
Also I found three places with missing keys:
History for a specific node:
Page in active workflow that can't be edited:
Settings:
Well spotted - I thought I'd got em all. Thought wrong. I'll fix those tomorrow morning and release a patch, but if you could send the Danish XML to nathan at nathanw dot com dot au I'll include it too, which will be awesome, thank you!
Perfect. I have send you an email with the danish XML file.
Magic! beta with those translations fixed, and the Danish lang file, is building now. Really appreciate the contribution, thank you.
Just installed 1.3.6 and it seems to work perfectly :-)
is working on a reply...