Using Umbraco Cloud - Since the upgrade from 7.15.4 to 7.15.5 whenever someone selects Save and Request Publish - they receive the notification error: Workflow: Unable to request publish, saving the content failed
Not an issue with the same code running 7.15.4. Anyone else experiencing?
It would be interesting to console.log out the contents of the 'notifications' object when the save occurs, eg did something change with the upgrade and notification types..
and also put a console log before the second version of the error message is displayed to determine if is is actually anything to do with the notifications or whether the error is thrown when $scope.save is called...
I've compared an empty solution with v7.15.4 and 7.15.5 and v7.15.5 is no longer returning a notification "Remember to publish to make changes visible". It looks as though there were some changes to the ContentController in 7.15.5 that may have affected this behaviour - https://github.com/umbraco/Umbraco-CMS/pull/1943
I think the most effective fix will be to separate the save + request publish. Haven't looked at the v7 version of Plumber in a while, but I think it has some funky stuff going on to make notifications friendly - it catches Umbraco notifications and in some cases replaces the message.
Will try to get around to this, got a couple of other bugs to look at too, but largely this version is critical/security fixes only, much like Umbraco 7.
Looks like there were changes to how notifications are managed internally in Umbraco, which broken some sniffing stuff I was doing. Should be ok again on the latest build.
upgrade to 7.15.5 issue
Using Umbraco Cloud - Since the upgrade from 7.15.4 to 7.15.5 whenever someone selects Save and Request Publish - they receive the notification error: Workflow: Unable to request publish, saving the content failed
Not an issue with the same code running 7.15.4. Anyone else experiencing?
Hi Samuel
That particular error message is thrown here: (in two places)
https://github.com/nathanwoulfe/Plumber/blob/f904978a14e1e7a06626510fd76bd2f1bcee9940/Workflow/App_Plugins/Workflow/Backoffice/controllers/workflow.drawerbuttons.controller.js#L82
It would be interesting to console.log out the contents of the 'notifications' object when the save occurs, eg did something change with the upgrade and notification types..
and also put a console log before the second version of the error message is displayed to determine if is is actually anything to do with the notifications or whether the error is thrown when $scope.save is called...
regards
Marc
Hi Marc,
I've compared an empty solution with v7.15.4 and 7.15.5 and v7.15.5 is no longer returning a notification "Remember to publish to make changes visible". It looks as though there were some changes to the ContentController in 7.15.5 that may have affected this behaviour - https://github.com/umbraco/Umbraco-CMS/pull/1943
Sam
Hi Samuel
I think the most effective fix will be to separate the save + request publish. Haven't looked at the v7 version of Plumber in a while, but I think it has some funky stuff going on to make notifications friendly - it catches Umbraco notifications and in some cases replaces the message.
Will try to get around to this, got a couple of other bugs to look at too, but largely this version is critical/security fixes only, much like Umbraco 7.
Hi Samuel
I've fixed this in the next patch release, you can grab the current build from https://ci.appveyor.com/project/nathanwoulfe/umbracoworkflow/builds/34176253/artifacts. Will publish to NuGet once I've resolved some other bits.
Looks like there were changes to how notifications are managed internally in Umbraco, which broken some sniffing stuff I was doing. Should be ok again on the latest build.
N
Hi Nathan.
Can You Plz Help Me how to Apply this fix I'm having the same issue
Thanks
You'll need to upgrade to Plumber 1.1.14, which can be done via NuGet or by installing the package via the zip file at the link in the comment above.
Thanks Nathan
No worries Samuel, grab the pre-release from https://ci.appveyor.com/project/nathanwoulfe/umbracoworkflow/build/artifacts
Found a couple of other issues, which are resolved in this one. Let me know if it's all cooperating and I'll push out a proper release.
N
is working on a reply...