Copied to clipboard

Flag this post as spam?

This post will be reported to the moderators as potential spam to be looked at


  • Tim Watts 90 posts 392 karma points
    Nov 02, 2017 @ 12:34
    Tim Watts
    0

    Plumber when user has no Update access to node

    Hi Nathan,

    Plumber is not working correctly with the user group permissions in 7.7.

    I have set up a standard Umbraco group which only has access to Browse a particular node, but with Plumber installed I still get options To Save, Request Publish, and Request Unpublish. In a different instance of a standard Umbraco install, without Plumber, I just see the Preview button.

    When I click on Save it correctly does not allow it, but it gives me a horrible red error message with the Json of the page content which is likely to scare many users!

    Unathorized Error

    So regardless of the Plumber workflow I have configured, if the User is in a Group which does not have access to Update a node then I would expect to only see the Preview button.

    Regards,

    Tim

  • Nathan Woulfe 411 posts 1530 karma points MVP 3x c-trib
    Nov 12, 2017 @ 01:06
    Nathan Woulfe
    0

    Ah, good catch - should be checking the Umbraco permissions on a node before modifying the drawer buttons.

    Will get to this as soon as I can

  • Nathan Woulfe 411 posts 1530 karma points MVP 3x c-trib
    Nov 12, 2017 @ 03:07
    Nathan Woulfe
    0

    Hi Tim

    Just pushed up a new version, I think it should resolve your issues - definitely fixes the SQL 2012 dependency, pretty sure it's sorted the issue with being able to action nodes when the user only has browse permissions (although any user with access to the workflow section will be able to cancel workflows on a node, they are essentially treated as workflow administrators regardless of their user permissions).

    Not sure about the issue you were having with setting the workflow on a node - I replicated your group set up and couldn't find the error. It did expose a couple of other minor bugs which I've since fixed as well (trying to remove all the approval groups from a node wouldn't save, and added clarity around how workflows are inherited and which has priority).

    Updated package is available here - https://ci.appveyor.com/project/nathanwoulfe/umbracoworkflow/build/0.2.0.73/artifacts

  • Tim Watts 90 posts 392 karma points
    Nov 13, 2017 @ 09:50
    Tim Watts
    0

    Thanks Nathan.

    I've moved onto other tasks on the project for the moment, but I'll hopefully look at it this week.

    Regards,

    Tim

  • Tim Watts 90 posts 392 karma points
    Nov 22, 2017 @ 09:38
    Tim Watts
    0

    Hi Nathan,

    I've installed the updated version this morning and it's looking a bit better.

    Take the following content tree:

    Home

    • Folder1
      • Page1
      • Page2
    • Folder2

    Default permissions are Browse Node, Create, Send to Publish etc. I have set granular permissions as Browse Node only on Folder1

    When I log in as that user and select Folder1 I now only get a Preview button as expected (no Save, Publish etc). However when I select Page1, or Page2 I get Save, Request Publish and Request Unpublish.

    Clicking Save on the child page gives me an "Authorization error", clicking either of the other two give an "OH SNAP!" error once I've filled in the comment and clicked save.

    Additionally if I try to Save my workflow settings (with or without changing any settings) I get the following error (with nothing in the log as far as I can see).

    Plumber error

    Regards,

    Tim

  • Nathan Woulfe 411 posts 1530 karma points MVP 3x c-trib
    Nov 22, 2017 @ 10:20
    Nathan Woulfe
    0

    Hi Tim

    Do you have any workflow configured for the site? Wondering if you might be getting the error on saving content as the package will be trying to initiate a workflow process but not finding any assigned groups?

    Will look into both.

    N

  • Tim Watts 90 posts 392 karma points
    Nov 22, 2017 @ 11:02
    Tim Watts
    0

    Hi Nathan,

    I have no workflow for the document type of Folder1 or Page1 in my example above. I do have some workflow configured for other document types.

    I get the same error as in my most recent screenshot above when I try to set an approval flow at the individual node level.

    Tim

  • Nathan Woulfe 411 posts 1530 karma points MVP 3x c-trib
    Jan 25, 2018 @ 10:30
    Nathan Woulfe
    0

    Hi Pradeep

    From version 0.2.x onwards I'm supporting Umbraco 7.7 minimum. Not sure though that your issues would be caused by the Umbraco version - the 7.7 restriction was for the improved user management UI.

    Will spin up a new 7.6.6 instance when I have time, and will get back to you.

  • Nicola Bigwood 28 posts 98 karma points
    Jan 25, 2018 @ 10:30
    Nicola Bigwood
    0

    Hi Pradeep,

    Apologies for jumping in here - but I had this initially as well. You need to grant access to users to see the Worfklow tab in the side bar. So you have to go to the Users part, then navigate to the user group you're assigned to, then 'add' the Workflow section. It'll then appear.

    sreenshot of access to sections including Workflow

    It looks like you don't have the Users tab either, though, so you might need to ask whoever set up your user account to allow you access to it.

    Once you can access the Workflow tab, you can then set up workflow approval - which will then appear in the 'Workflow approval flow' panel from your screenshot.

    Hope that helps!

  • Nathan Woulfe 411 posts 1530 karma points MVP 3x c-trib
    Jan 25, 2018 @ 10:32
    Nathan Woulfe
    0

    Thanks Nicola, that's likely it.

    Might update the installer to automatically grant access to all site administrator users...

  • Tim Watts 90 posts 392 karma points
    Nov 22, 2017 @ 11:46
    Tim Watts
    0

    I've just noticed I'm actually getting an "Oh Snap" error whenever I send anything to publish, regardless of the user permissions on the particular node.

    Tim

  • Nathan Woulfe 411 posts 1530 karma points MVP 3x c-trib
    Nov 23, 2017 @ 05:38
    Nathan Woulfe
    0

    Hi Tim

    Just pushed up a new version - I was previously using the same function to update permissions when set for a node or doc type, but have split this into separate methods, which will resolve the saving settings issue.

    Also added a check for a valid workflow set on the hompage node - this is the absolute minimum config required, so if it's missing, I'm now displaying a notification and only the preview button.

    I've tested both locally and have not seen any errors. Let me know how you get on.

    https://ci.appveyor.com/project/nathanwoulfe/umbracoworkflow/build/artifacts

  • Tim Watts 90 posts 392 karma points
    Nov 23, 2017 @ 13:29
    Tim Watts
    0

    Sorry Nathan, I'm having different problems now.

    I've tried an install over the top, and a fresh install of 0.2.0.078.

    I can view the workflow dashboard section okay, but can't do much more than that.

    Clicking on Approval Groups/My group gives a 404 (/App_Plugins/Workflow/backoffice/approval-groups/edit.html), adding a new group also gives a 404. Clicking on History or Settings takes me straight to the Content root.

    The chart and documentation tabs are showing. I can set the workflow configuration on the content tree without issue.

    Looking into the 404 problem, and at your project on GitHub I think there are a few views missing from the build, I do not have a folder App_Plugins\workflow\backoffice\approval-groups. It works okay when I manually add these files.

    I can't identify the cause for not being able to view the workflow settings or history pages though.

    Tim

  • Nathan Woulfe 411 posts 1530 karma points MVP 3x c-trib
    Nov 24, 2017 @ 00:52
    Nathan Woulfe
    0

    My fault - needed to add a reference to a new folder in my gruntfile, without it the approval-groups folder wasn't copied into the package by the build process.

    Same issue mean the routing changes weren't included, which would have broken the settings/history views.

    New build is available now.

  • Tim Watts 90 posts 392 karma points
    Nov 24, 2017 @ 08:37
    Tim Watts
    0

    Hi Nathan,

    I've installed 0.2.0.80

    I'm now getting a different 404 on saving workflow /umbraco/backoffice/api/workflow/config/save

    This is the same error on document type approvals in Workflow settings, and content node approvals.

    But I can now see the settings and history okay.

    Tim

  • Nathan Woulfe 411 posts 1530 karma points MVP 3x c-trib
    Nov 24, 2017 @ 09:00
    Nathan Woulfe
    1

    That route shouldn't exist - the changes in a previous commit split those to /config/saveconfig and /config/savedoctypeconfig, for the node-based and doctype-based configs respectively.

    Did you uninstall then reinstall, or just update files? Sounds like it could be some JS cached in the backoffice hanging onto the old routes. What do the saveConfig and saveDocTypeConfig functions in workflow.resource look like?

  • Tim Watts 90 posts 392 karma points
    Nov 24, 2017 @ 09:38
    Tim Watts
    0

    I'm having problems installing any package in that particular environment (similar to this: different grant set message). I've been installing the package over the top in a local environment, and then copying the app_plugins and dll across!

    Refreshing the cache has sorted it.

    Thanks,

    Tim

  • Nathan Woulfe 411 posts 1530 karma points MVP 3x c-trib
    Nov 26, 2017 @ 00:54
    Nathan Woulfe
    1

    No worries, glad you got it sorted

    Appreciate your feedback too, helped to expose a few bugs and bits that I'd missed.

  • Nicola Bigwood 28 posts 98 karma points
    Dec 04, 2017 @ 09:29
    Nicola Bigwood
    0

    Hi Nathan,

    I'm picking this up from Tim.

    The button options presented to users once a page has been submitted to the workflow are the wrong way round, i.e. an admin user (with permission to publish) sees an option only to 'Cancel workflow' whereas a writer (without permission to publish) sees options to 'Approve changes', 'Reject changes' or 'Cancel workflow'.

    These options are seen when a user either selects ‘Edit’ from the dashboard or just navigates to the page in question in the back office.

    Admin (with permission to publish) sees:

    enter image description here

    whereas a writer (without permission to publish) sees:

    enter image description here

    The approval groups and workflow are configured correctly (Tim also checked) – just the button options seem to have been applied the wrong way round. Tim thinks this wasn’t a problem in the last release. (And just to clarify, the button options before a page is submitted to the workflow are correct - it's just afterwards that they're not).

    Is this something you'd be able to fix for us?

    Thanks!

    Nicola.

  • Nathan Woulfe 411 posts 1530 karma points MVP 3x c-trib
    Dec 18, 2017 @ 22:46
    Nathan Woulfe
    0

    Hi Nicola

    I've just released a new build, should resolve the button issues. It's available here - https://ci.appveyor.com/project/nathanwoulfe/umbracoworkflow/build/artifacts

    Change -

        vm.buttonGroup = {
          defaultButton: vm.canAction ? buttons.approveButton : vm.adminUser ? buttons.cancelButton : null,
          subButtons: vm.canAction ? [buttons.rejectButton, buttons.cancelButton] : []
      };
    

    Change means a user with permission to action an active workflow will have the approve button, with reject and and cancel as the sub-buttons, and any admin user (admin in this context is a user with access to the workflow section) will have a cancel button only, if the current node is in a workflow.

    Keep in mind that the permissions for the workflow are completely separate from Umbraco's roles/permissions - any member of the final group in a workflow will be able to publish changes to the live site.

  • Nicola Bigwood 28 posts 98 karma points
    Dec 19, 2017 @ 09:38
    Nicola Bigwood
    0

    Hi Nathan,

    Thanks for getting back to me so quickly.

    In our setup, we've only allowed editors and writers to see the content and media sections of the sidebar - so they wouldn't see the workflow section there. Is that what you mean by "access to the workflow section"?

    Apologies for all the daft questions but I'm not a developer :)

    I'll pass this on the team so we can try it out - thank you!

    Nicola.

  • Nathan Woulfe 411 posts 1530 karma points MVP 3x c-trib
    Dec 19, 2017 @ 09:45
    Nathan Woulfe
    0

    Yup, exactly that - if the workflow if nnis in the sidebar, they'll be treated as a workflow admin, which means they can cancel any current workflow.

    Permissions-wise, any user in the final group of a workflow will be able to publish, regardless of their actual user permissions. By being part of the workflow group, their permissions are elevated so that they can administer the workflow.

  • Nicola Bigwood 28 posts 98 karma points
    Dec 19, 2017 @ 09:54
    Nicola Bigwood
    0

    We never want writers to be able to approve changes and publish the page, though - so if they're not in an approval group, they won't have their permissions elevated, will they? (sorry if I've misunderstood - I'm sure it'll make more sense once I'm using it!).

  • Nathan Woulfe 411 posts 1530 karma points MVP 3x c-trib
    Dec 19, 2017 @ 10:04
    Nathan Woulfe
    0

    That makes sense - you'd have editors in the workflow groups, writers would just be business as usual, with their changes being sent for approval, which initiates the workflow.

    Will be clearer once you start playing with it.

  • Nicola Bigwood 28 posts 98 karma points
    Dec 19, 2017 @ 10:22
    Nicola Bigwood
    0

    Great - thank you! And yes, I'm sure it will - it was all looking great in the last release, and ticking off lots of boxes from my backlog :) Thanks again!

  • Nicola Bigwood 28 posts 98 karma points
    Jan 24, 2018 @ 11:25
    Nicola Bigwood
    0

    Hi again Nathan (happy new year!)

    Our Content team (stakeholders) have been trying out Plumber. They're much happier with the buttons having been switched round, so thanks very much for having sorted that!

    I've got a couple of questions, though, from their testing.

    1. If a user submits a page to the workflow using the 'Request publish' button but without having first saved the page, the edits they've made are not saved and carried through. In other words, when the Admin user then goes to preview the page before approving it, they see the page in its last published state without the edits. This means they're not able to approve what they're meant to be trying to approve.

    Is this expected? Or can the 'Request publish' button incorporate a save?

    2. If a user goes to a page that's currently in workflow, they can add extra edits to that page. If they navigate away again, those changes can be discarded. If they stay on the page and preview, however, those changes are saved. When an approver then looks at that page as part of the approval stage of the workflow process, they don't only see the original edits (the ones submitted to the workflow) but they also see the subsequent extra edits.

    Is it possible to "lock" a page, so that if it's already in a workflow no subsequent changes to it are saved? (Or, if they are saved, the page has to go through the workflow again for them to take effect?). An editor might think they've submitted certain content for approval, while an Admin actually sees completely different content.

    Thanks very much!

    Nicola.

  • Nathan Woulfe 411 posts 1530 karma points MVP 3x c-trib
    Jan 24, 2018 @ 21:06
    Nathan Woulfe
    0

    Hi Nicola

    I'd written a lengthy, well-rounded response (at least, I thought it was), then tapped the back button in my phone and lost it...

    Short of it was I can certainly improve both those cases.

    User feedback trumps testing any day, so thank you.

  • Nathan Woulfe 411 posts 1530 karma points MVP 3x c-trib
    Jan 25, 2018 @ 06:14
    Nathan Woulfe
    0

    Hi Nicola

    Just updated the package, should resolve both these issues.

    1 - if changes have been made to a page, the request publish button is replaced by save. request publish is only displayed when the page is unmodified or freshly saved 2 - only users in the current workflow approval group are shown the action buttons, all other users only see the preview button, which no longer performs a save on content already in a workflow

    Latest version is here - https://ci.appveyor.com/project/nathanwoulfe/umbracoworkflow/build/artifacts

  • Nicola Bigwood 28 posts 98 karma points
    Jan 25, 2018 @ 08:15
    Nicola Bigwood
    0

    Hi Nathan,

    Wow, that was fast! Brilliant - thank you! I'll get this update installed in our next sprint and let you know if we have any more feedback!

    Thank you!

    Nicola.

  • Nathan Woulfe 411 posts 1530 karma points MVP 3x c-trib
    Jan 25, 2018 @ 08:22
    Nathan Woulfe
    0

    No worries at all - great to get feedback for actual use cases rather than me just trying to think of scenarios!

    Keep it coming!

  • Nicola Bigwood 28 posts 98 karma points
    Feb 28, 2018 @ 08:53
    Nicola Bigwood
    0

    Hi Nathan,

    I see you've added a new build - but just in case this is still relevant, I have feedback on the last version mentioned above, 0.2.0.04 - so apologies if these have been covered in the newer build already!

    The big red error message, like the one Tim posted at the top of this thread, has returned - which displays when a user tries to edit/save/publish a page they don't have permission to edit/publish etc.

    1. Is it possible to have a more editor-friendly error message i.e. without all the json, and perhaps simply telling them that their current permission levels don't allow them to edit the page (to reassure them they haven't actually broken anything!).

    2. Is it possible to have all messages - both error and confirmation - on top? For instance, the confirmation that workflow has been set on a node appears behind the pane:

    confirmation alert is hidden by node workflow pane

    and an error alert when there's an issue creating a new group:

    enter image description here

    which makes it hard for the user to see what's gone wrong.

    (I've got some other points for feedback but I'll put them in another thread as they're not to do with when a user doesn't have update access.)

    Thanks!

  • Nathan Woulfe 411 posts 1530 karma points MVP 3x c-trib
    Feb 28, 2018 @ 09:07
    Nathan Woulfe
    0

    Hi Nicola

    I'll need to double check on the current version, but pretty sure this has been resolved...

    N

  • Nicola Bigwood 28 posts 98 karma points
    Feb 28, 2018 @ 09:12
    Nicola Bigwood
    0

    Great - thank you! (Sorry - I found your version history after I started posting, but as I'm not a developer I didn't want to risk misunderstanding what was listed!)

Please Sign in or register to post replies

Write your reply to:

Draft