Copied to clipboard

Flag this post as spam?

This post will be reported to the moderators as potential spam to be looked at


  • Kevin Jump 2310 posts 14695 karma points MVP 7x c-trib
    Dec 03, 2018 @ 19:51
    Kevin Jump
    0

    Hi,

    I've got a peice of content that has been rejected in workflow, but now when you go to it, you get Document is in workflow, and you can't seem to get it out

    enter image description here

    Suspect i am missing a step somewhere ?

  • Nathan Woulfe 447 posts 1664 karma points MVP 5x hq c-trib
    Dec 03, 2018 @ 20:06
    Nathan Woulfe
    0

    Hi Kevin

    First thing I'd check is that the user has permission to action the workflow - if they do, there's definitely something wrong...

    Any JavaScript errors in the console?

    What version are you running? There were some issues with the button stated not syncing correctly in an older release.

  • Kevin Jump 2310 posts 14695 karma points MVP 7x c-trib
    Dec 03, 2018 @ 20:17
    Kevin Jump
    0

    yeah its the main site admin, who is also in the worflow group created for the workflow "site admins" group -

    the config for the page shows the workflow :

    enter image description here

    version 1.0.3

    No javascript errors on the page - but there is one on workflow dashboard.

    {
       "ExceptionType":"NullReferenceException",
        "ExceptionMessage":"Could not get log dates","StackTrace":"   at Workflow.Api.LogsController.GetDateList()"
    }
    

    if its not obvious i might just dive into the code/db and see what i can find.

  • Nathan Woulfe 447 posts 1664 karma points MVP 5x hq c-trib
    Dec 03, 2018 @ 20:23
    Nathan Woulfe
    0

    That log error has been on my to-fix list for a while - it's an error thrown when there are no errors in the log, which in turn adds an error to the logs, and effectively fixes itself...

    I'll have a look into this one too, was certain it was fixed, but it's probably related to the workflow only being a single step - there's noone to reject the change back to (or the code assumes a group, not the original editor)

  • Nathan Woulfe 447 posts 1664 karma points MVP 5x hq c-trib
    Dec 06, 2018 @ 07:30
    Nathan Woulfe
    0

    Hi Kevin

    Had a chance to dig around a bit, I think this is working correctly, if not clearly.

    I've done the following to reproduce:

    • set a single group as the inherited approval group on the home node
    • edited a piece of content, as a user NOT in that approval group
    • submitted for approval
    • switched to the approving group
    • rejected content

    When I log back in as the original editor, I can edit the content and resubmit for approval. If I log back in as a member of the approving group (prior to having resubmitted), I can cancel from the dashboard, but not from the node itself).

    I think what should be happening is that admin-type users should always have full access to circumvent workflow (ie should have the complete set of options in the editor drawer menu, regardless of the content state).

    Can you confirm for me that the dashboard gives the option to cancel? I'll get an update out with the admin permissions fixed too.

  • Nathan Woulfe 447 posts 1664 karma points MVP 5x hq c-trib
    Dec 06, 2018 @ 07:48
    Nathan Woulfe
    2

    And a bit more digging - I had a misnamed variable (adminUser vs isAdmin) so the condition for displaying the cancel button was never true for rejected content, so never displayed.

    Will patch and push.

  • Kevin Jump 2310 posts 14695 karma points MVP 7x c-trib
    Dec 06, 2018 @ 09:45
    Kevin Jump
    0

    woot !

    you rock, thanks again .

Please Sign in or register to post replies

Write your reply to:

Draft