Copied to clipboard

Flag this post as spam?

This post will be reported to the moderators as potential spam to be looked at


  • Richard Eyres 95 posts 556 karma points
    Jan 17, 2019 @ 16:55
    Richard Eyres
    0

    Script errors, unable to create approval flow

    I am looking at this package for a client, as it seems to fit all of their fairly basic needs. And what i have seen so far is good.

    After a few hiccups, i installed the latest version via nuget (1.1.2) (it wants to update our web.config, which has extra non umbraco areas, which it deleted). I was able to create an Approval Group without any issues (or so i believe).

    When i try to create Content Type Approval Flow item (this is for a news item) it doesn't do anything. Console is showing some JS errors. I have cleared the client dependency and increased the version.

    enter image description here

    Umbraco Version: 7.12.3, which has been upgraded since early version 7.

    Any insight into the possible issues would be greatly appreciated. If more information is required, then please let me know.

  • Nathan Woulfe 377 posts 1449 karma points MVP 2x c-trib
    Jan 17, 2019 @ 22:47
    Nathan Woulfe
    0

    Thanks Richard, working on this now - it's nothing major in itself, but has highlighted a couple of other minor UI bits needing a tweak.

    Will let you know when it's sorted.

    N

  • Richard Eyres 95 posts 556 karma points
    Jan 18, 2019 @ 09:02
    Richard Eyres
    0

    Hello Nathan

    Awesome. Look forward to hearing from you when ready.

  • Nathan Woulfe 377 posts 1449 karma points MVP 2x c-trib
    Jan 18, 2019 @ 09:15
    Nathan Woulfe
    100

    No worries!

    Should be working now, pretty sure - https://ci.appveyor.com/project/nathanwoulfe/umbracoworkflow/build/artifacts has a link to the latest build

    If you can confirm that it's working, I'll package up the release.

  • Richard Eyres 95 posts 556 karma points
    Jan 18, 2019 @ 10:22
    Richard Eyres
    0

    Hello Nathan

    I have just tested, and it is now allowing me to add the Content Type Approval.

    I have done a 'very' quick test on a single amend to an item covered by the above Content Type, and it looks like it is working.

    This is the first time i have used this product, so i still need to fully get to grips with it, but i have moved on.

    There is still the JS issue of the Maximum call stack size exceeded (first JS error on my image). Not sure if that is important or not (this site has a number of different languages and a lot of content and document types).

    Thank you for your very prompt reply to this issue.

  • Nathan Woulfe 377 posts 1449 karma points MVP 2x c-trib
    Jan 18, 2019 @ 10:38
    Nathan Woulfe
    0

    I'll have another look and see if I can replicate the stack error - it's thrown at the same line as the original issue, so I'd assumed the two were related.

    Will get a patch release out soon.

  • James 4 posts 74 karma points
    1 week ago
    James
    0

    Did the "Maximum call stack size exceeded" origin become known? I just upgraded to Umbraco 7.15.3 and am getting this error. Fixed it by replacing 3 instances of _typeof(something) with typeof(something) - removing the underscore. workflow.js error Seems like typeof is getting replaced by _typeof somehow and causing a self-reference. line 12 of workflow.js [corrected]:

    function _typeof(obj) { 
    if (typeof Symbol === "function" && typeof(Symbol.iterator) === "symbol") { 
        _typeof = function (_typeof2) { 
            function _typeof(_x) { 
                return _typeof2.apply(this, arguments);
            } 
            _typeof.toString = function () { 
                return _typeof2.toString();
            };
            return _typeof;
        }
        (function (obj) { 
            return typeof obj === "undefined" ? "undefined" : typeof(obj); 
        }); 
    } else { 
        _typeof = function (_typeof3) { 
            function _typeof(_x2) { 
                return _typeof3.apply(this, arguments); 
            }
            _typeof.toString = function () {
                return _typeof3.toString(); 
            };
            return _typeof;
        }
        (function (obj) {
            return obj && typeof Symbol === "function" && obj.constructor === Symbol && obj !== Symbol.prototype ? "symbol" : typeof obj === "undefined" ? "undefined" : typeof(obj); 
        }); 
    }
    return _typeof(obj); 
    

    }

    typeof(Symbol.iterator)
    

    and two instances of

    typeof obj === "undefined" ? "undefined" : typeof(obj); 
    

    Could Umbraco be using babel/reactjs and be causing this? https://stackoverflow.com/questions/35392666/babel-requirejs-typeof-rangeerror-maximum-call-stack-size-exceeded

  • Nathan Woulfe 377 posts 1449 karma points MVP 2x c-trib
    1 week ago
    Nathan Woulfe
    0

    That's all compiled JavaScript - I have a transpiling step in the build to target es5, so possibly something is getting mixed up in that process. Updating anything in the workflow.js file won't be conclusive.

    It's all open source of you feel like pulling down the source and finding the original source of the problem.

    Are you using the latesr plumber release?

  • James 4 posts 74 karma points
    1 week ago
    James
    0

    plumber - v1.1.12-build402 - 2020-01-24

Please Sign in or register to post replies

Write your reply to:

Draft