Hi Lars-Erik,

thanks for your bugreport. Appreciated :)

I can confirm that this bug exists, and also if I add a new UrlContentFinder myself it does not work as it should work.

Can I borrow your brilliant mind for a moment to think along with us.

My code for the UrlContentFinder is this (in a default Umbraco starter kit solution on 8.6.x with uMarketingSuite 1.3 installed):

using ClientDependency.Core.Logging; using System; using System.Collections.Generic; using System.Linq; using System.Web; using Umbraco.Core.Composing; using Umbraco.Core.Configuration; using Umbraco.Core.Configuration.UmbracoSettings; using Umbraco.Core.Models.PublishedContent; using Umbraco.Web; using Umbraco.Web.Routing;

namespace umsMetVirtualNodes.Code { public class StartUpProvider : IUserComposer { public void Compose(Composition composition) { composition.UrlProviders().InsertBefore

public class JeffreysUrlProvider : DefaultUrlProvider
{

    public JeffreysUrlProvider(IRequestHandlerSection requestSettings, Umbraco.Core.Logging.ILogger logger, IGlobalSettings globalSettings, ISiteDomainHelper siteDomainHelper) : base(requestSettings, logger, globalSettings, siteDomainHelper)
    {
    }

    public override IEnumerable<UrlInfo> GetOtherUrls(UmbracoContext umbracoContext, int id, Uri current)
    {
        return base.GetOtherUrls(umbracoContext, id, current);
    }

    public override UrlInfo GetUrl(UmbracoContext umbracoContext, IPublishedContent content, UrlMode mode, string culture, Uri current)
    {

        //Just in case
        if (content == null)
        {
            //otherwise return the base GetUrl result:
            return base.GetUrl(umbracoContext, content, mode, culture, current);
        }

        //If this is a virtual node itself, no need to handle it - should return normal URL
        if (content.ContentType.Alias == "product")
        {
            UrlInfo defaultUrlInfo = base.GetUrl(umbracoContext, content, mode, culture, current);
            var originalUrl = defaultUrlInfo.Text.Substring(0,defaultUrlInfo.Text.Length -1);
            var customUrl = originalUrl + "-" + content.Id.ToString() + "/";
            return new UrlInfo(customUrl, true, defaultUrlInfo.Culture);                
        }

        return null;
    }
}

}

This will result in url's like https://localhost:44336/products/biker-jacket-1104/ where I only added in the ID of the node at the end of the url.

Question 1) I've implemented a UrlProvider and I expected this to generate url, but not map this back to the content. I thought I would have to implement a ContentFinder as well. But somehow this url magically gives me back to the correct content. Do you have any idea how that dark magic works?

In the DotSee.VirtualNodes package there is a content finder registered, so that is another case.

The way our code works is that does something like this:

var req = _publishedRouter.CreateRequest(reference.UmbracoContext, uri);
                    if (_publishedRouter.TryRouteRequest(req))
                    {
                        var content = req.PublishedContent;
                        var culture = req.Culture;

Given the incoming url we ask Umbraco (via the IPublishedRouter instance) to give us a possible node... If it gives us a node, we know it's internal and register it correctly in our table (so we can show in the Analytics-view)... But somehow this call in the case of DotSee.VirtualNodes does not map back correctly.

Question 2) Any idea why this wouldn't work or any advice on a better alternative?

We will look into this later this week as well, but maybe you spot something already.

Thanks in advance,

Jeffrey

Author of VirtualNodes here. Don't know whether I could contribute anything to this particular issue, but please do let me know if so.

Seems good now! 👍

is working on a reply...