Copied to clipboard

Flag this post as spam?

This post will be reported to the moderators as potential spam to be looked at


  • Bjarne Fyrstenborg 1142 posts 3247 karma points MVP 3x c-trib
    Aug 14, 2014 @ 15:21
    Bjarne Fyrstenborg
    0

    SEO Checker datatype - horizontal scrollbar

    When adding a property using SEO Checker datatype, it seems to cause overflow and therefore horizontal scrollbar. Because of this issue the buttons overlap the horizontal scrollbar. And in my case there doesn't seems to be the need for horizontal scroll.

    Perhaps there are the much right margin somewhere, otherwise there could also be added overflow: hidden here to prevent this:

    <div ng-controller="seoChecker.seoCheckerPropertyEditorController" class="ng-scope" style="
        overflow: hidden;
        ...
    </div>

    /Bjarne

  • Richard Soeteman 3722 posts 11521 karma points MVP
    Aug 14, 2014 @ 15:25
    Richard Soeteman
    0

    Hi Bjarne,

    Which version are you using? I've changed something in the latest version and can't see it in my local environment. Is it possible to send a screenshot if you are using the latest version?

    Thanks,

    Richard

  • Bjarne Fyrstenborg 1142 posts 3247 karma points MVP 3x c-trib
    Aug 14, 2014 @ 15:36
    Bjarne Fyrstenborg
    0

    Hi Richard

    I am using Umbraco 7.1.4. and SEO Checker 1.6.. you might not see it depending on your screen resolution, but I think you'll see it, if you resize the browser window.

    Notice you almost don't see it, because the buttons overlap the scrollbar.

    /Bjarne

  • Richard Soeteman 3722 posts 11521 karma points MVP
    Aug 14, 2014 @ 15:39
    Richard Soeteman
    0

    Ah I see thanks

    Will have a look tomorrow. Must be easy to fix :)

  • Bjarne Fyrstenborg 1142 posts 3247 karma points MVP 3x c-trib
    Aug 14, 2014 @ 15:42
    Bjarne Fyrstenborg
    0

    Just annoying for my eyes :) :p

    But the issue with the buttons overlapping the scrollbar should be fixed anyway.. might look into to fix this :)

    /Bjarne

  • Richard Soeteman 3722 posts 11521 karma points MVP
    Aug 15, 2014 @ 14:04
    Richard Soeteman
    0

    Hi Bjarne,

    The issue is fixed for the next release. In case you already want to use the changes, install the package file below. Make sure to clear the cache.

    https://www.dropbox.com/s/hctibuqcuplxort/seochecker-1.6.1.zip

    Best,

    Richard

  • Bjarne Fyrstenborg 1142 posts 3247 karma points MVP 3x c-trib
    Aug 15, 2014 @ 15:29
    Bjarne Fyrstenborg
    0

    Hi Richard

    I just updated the package and cleared the cache, but see the issue because of this css style:

    .sc-control {
    margin-left: 240px;
    width: 83.5%;
    }

    no need to set the width of the container as I might work well on larger screen, but not on smaller ones.

    It would be better to change it to:

    .sc-control {
        margin-left: 240px;
    }
    .sc-control textarea {
        width: 80%;
    }
    .sc-caption {
        margin-top: 5px;
        margin-right: 20%;
    }
    .seoCharacterValidation {
        width: 100%;
        text-align: right;
    }

    Perhaps change margin-right for .sc-caption to around 18-19% to take into account the padding in the textarea.

    /Bjarne

  • Richard Soeteman 3722 posts 11521 karma points MVP
    Aug 18, 2014 @ 10:09
    Richard Soeteman
    0

    Hi Bjarne,

    Thanks for sharing and I've added the changes. Only text area was to big so I slimmed it down. You can try yourself by installing https://www.dropbox.com/s/hctibuqcuplxort/seochecker-1.6.1.zip

    Thanks,

    Richard

  • Bjarne Fyrstenborg 1142 posts 3247 karma points MVP 3x c-trib
    Aug 18, 2014 @ 10:25
    Bjarne Fyrstenborg
    0

    Hi Richard

    Yes, but with the my css changes the character count label is also located at the bottom right of the textarea. Right now i depends on the screen resolution / browser window size.

    As it is now:

    With my changes:

     

     

    On smaller screen resolutions to character count might cause overflow, because it goes out of screen space before the textarea. And then the changes I wrote above just requires fewer css styles :)

    Because of textarea has some padding and border the .sc-caption could has margin-right to around 18-19% to be closer to the right border of the textarea.

    /Bjarne

  • Richard Soeteman 3722 posts 11521 karma points MVP
    Aug 18, 2014 @ 10:40
    Richard Soeteman
    0

    Ah I see the scrollbar is back. But not anymore with these changes https://www.dropbox.com/s/hctibuqcuplxort/seochecker-1.6.1.zip can even look on my phone now :)

  • Bjarne Fyrstenborg 1142 posts 3247 karma points MVP 3x c-trib
    Aug 18, 2014 @ 10:43
    Bjarne Fyrstenborg
    0

    Is that package version updated since the other day or? :)

  • Richard Soeteman 3722 posts 11521 karma points MVP
    Aug 18, 2014 @ 10:46
    Richard Soeteman
    0

    Nope package version is the one that will be when once released as final...

  • Bjarne Fyrstenborg 1142 posts 3247 karma points MVP 3x c-trib
    Aug 27, 2014 @ 23:59
    Bjarne Fyrstenborg
    0

    Hi Richard..

    I have upgraded to Umbraco 7.1.6 and the release of SEO Checker 1.6.1., but there seem still to be the issue with horizontal scroll. I have also cleared the cache.

    Have your tried with the styles I wrote?

    E.g. for class sc-control it has:

    .sc-control {
       margin-left: 240px;
       width: 83.5%;
    }

    instead of just:

    .sc-control {
        margin-left: 240px;
    }

     

    So I would suggest these changes:

    .sc-control {
        margin-left: 240px;
    }
    .sc-control textarea {
        width: 80%;
    }
    .sc-caption {
        margin-top: 5px;
        margin-right: 20%;
    }
    .seoCharacterValidation {
        width: 100%;
        text-align: right;
    }

    Including removing other styling not shown in the css here for these elements.

    And margin-right for .sc-caption could be change from 20% to around 18-19% to take into account the padding in the textarea and therefore be closer to the textarea right border.

    Thanks,
    Bjarne 

  • Richard Soeteman 3722 posts 11521 karma points MVP
    Aug 28, 2014 @ 10:09
    Richard Soeteman
    0

    Weird I think the build configuration didn't include the new CSS will do that for a next version. SOrry for the hassle.

  • Bjarne Fyrstenborg 1142 posts 3247 karma points MVP 3x c-trib
    Sep 26, 2014 @ 23:36
    Bjarne Fyrstenborg
    0

    Hi Richard

    I have updated to v. 1.7 of Seo Checker, but unfortunately it still seem to have the old styling, which cause horizontal scrollbar. Is the new CSS included corectly in the build of the package?

    /Bjarne

  • Richard Soeteman 3722 posts 11521 karma points MVP
    Oct 01, 2014 @ 14:17
    Richard Soeteman
    100

    Hi Bjarne,

    Sorry, the notification mail ended up in the spam folder and the css wasn't included in the build process for release. Will be for the next version 1.8 which should be out this week...

    Best,

    Richard

  • Bjarne Fyrstenborg 1142 posts 3247 karma points MVP 3x c-trib
    Oct 02, 2014 @ 22:06
    Bjarne Fyrstenborg
    0

    Hi Richard

    Thanks for fixing this in v. 1.8 :)

    Cheers,
    Bjarne 

Please Sign in or register to post replies

Write your reply to:

Draft