Hi,

I have extended the IShippingCalculator to apply some rules for shipping costs and this is working well.

However: I have a basket page which allows users to update order quantities. When you update the quantities this can result in a change to the shipping calculation. The calculation itself appears to work fine, however the delivery cost is not updated when I re-render the basket. The process I've tried is:

1. Arrive on basket page with order with a low value that attracts a shipping fee
2. Update the order quantity so that the shipping is now free and submit
3. The posted quantity changes are handled in the page's razor scripting and TC.UpdateOrderLine is called.
4. The basket is then re-rendered, using the order object
5. The total price and delivery price do not reflect the changes
6. Refresh the page and all the costs are now fine.

As a work around I tried doing a response.redirect if the delivery rules have changed the price, but this doesn't help. It seems to only be refreshing that results in the order values being updated.

Is there anything obvious about this approach that might cause this?

For what it's worth, here is my current shipping price calculator. The part where I'm saving the order is only a recent addition when trying some things out to see if I could work around the problem.

Many thanks in advance for any advice.

Tim

    [SuppressDependency("TeaCommerce.Api.PriceCalculators.IShippingCalculator", "TeaCommerce.Api")]
    public class CustomShippingCalculator : ShippingCalculator
    {
        public CustomShippingCalculator(IVatGroupService vatGroupService, ICurrencyService currencyService)
            : base(vatGroupService, currencyService)
        {
        }
        protected override decimal CalculatePrice(ShippingMethod shippingMethod, Currency currency, Order order)
        {
            long countryId = order.ShipmentInformation.CountryId ?? default(long);
            long? countryRegionId = order.ShipmentInformation.CountryRegionId;
            decimal currentShippingPrice = shippingMethod.GetOriginalPrice(currency.Id, countryId, countryRegionId);
            var deliveryThresholdSettings = new Node(1225); //delivery settings node
            var lastAppliedThreshold = -1m;
            foreach (var child in deliveryThresholdSettings.ChildrenAsList)
            {
                var price = 0m;
                var basketValue = 0m;
                if (decimal.TryParse(child.GetProperty("deliveryPrice").Value, out price) && decimal.TryParse(child.GetProperty("basketValue").Value, out basketValue))
                {
                    if (basketValue > lastAppliedThreshold)
                    {
                        if (basketValue <= order.TotalPrice.Value)
                        {
                           //Log.Add(LogTypes.Notify, 1225, "Found delivery rule, setting price as " + price);
                            currentShippingPrice = price;
                            lastAppliedThreshold = basketValue;
                        }
                    }
                }
            }
            if (order.ShipmentInformation.TotalPrice.Value != currentShippingPrice)
            {
                order.ShipmentInformation.TotalPrice = new Price(currentShippingPrice, order.VatRate, currency);
                order.Save();
            }
            return currentShippingPrice;
        }
    }