Copied to clipboard

Flag this post as spam?

This post will be reported to the moderators as potential spam to be looked at


  • Bjarne Fyrstenborg 1239 posts 3670 karma points MVP 5x c-trib
    Jun 02, 2014 @ 19:22
    Bjarne Fyrstenborg
    0

    Feedback on Tea Commerce for Umbraco 7

    I just tested the latest version af Tea Commerce v. 2.3.1 with Umbraco 7.1.4 and I have some suggestions for improvements:

     

    • When you choose "cancel" in "Sort"-panel, the panel doesn't close.
    • If you reload a parent node, which doesn't have children you'll get an server error: Failed to retrieve data for child nodes undefined. E.g. if you choose "reload nodes" before you create a store first time or reload nodes for a country e.g. the default Jamaica. It seems it have two levels - I guess it's because you can group it into regions like Europe -> Denmark, Germany, .... North America -> USA, Canada.... 

    • Click on many of the parent nodes return: Request error: The URL returned a 404 (not found): views/tea-commerce-store-tree/edit.html
    • For image to shipping method or payment method you can choose the Media root node If you afterwards click "delete"it returns HTTP Error 403.14.

    • Maybe consider to style dialogs like "create" and "sort" consistency with Umbraco's dialog.
    Sort dialog for Tea Commerce.
    Sort dialog for Umbraco.
    Create dialog for Tea Commerce.
    Create dialog for Umbraco - e.g. create new stylesheet, template..
    /Bjarne

     

  • Bjarne Fyrstenborg 1239 posts 3670 karma points MVP 5x c-trib
    Jun 02, 2014 @ 19:48
    Bjarne Fyrstenborg
    0

    Futhermore, if it's the case you can group the countries into multiple levels then the second level is missing "Default currency" incl. in the dialog:

     

    Jamaica:

    Test:

     

  • Anders Burla Johansen 2560 posts 8256 karma points
    Jun 03, 2014 @ 14:55
    Anders Burla Johansen
    0

    Hi Bjarne

    Thanks for your great feedback!!

    Regarding the default curreny - this is by design. A country region (like a state) dont have a different currency thatn its parent country (USA). So that is why :)

    Kind regards
    Anders

  • Bjarne Fyrstenborg 1239 posts 3670 karma points MVP 5x c-trib
    Jun 03, 2014 @ 15:04
    Bjarne Fyrstenborg
    0

    Hi Anders

    Okay, so the structure is intended to be like:

    • USA
      • AL
      • AK
      • AZ
      • ...
    • ...
    • ...
    not like:
    • Europe
      • Denmark
      • Germany
      • United Kingdom
      • ...
    • ...
    • ...
    because then it would make sense to have default currency for the child levels :)
    /Bjarne
  • Bjarne Fyrstenborg 1239 posts 3670 karma points MVP 5x c-trib
    Jul 06, 2014 @ 17:39
    Bjarne Fyrstenborg
    0

    Hi Anders

    I noticed a minor issue in the "Search criteria" area in Tea Commerce 2.3.2 - it might also be an issue in previously versions.
    The for attribute refers to a different id and I think you just forgot to change it to a different field.

    <divclass="umb-el-wrap ">
    <labelclass="control-label"for="inputPassword">Order number</label>
    <divclass="controls controls-row">
       
    <inputname="ctl00$ctl00$body$TxtOrderNumber"type="text"id="body_TxtOrderNumber"class="guiInputText guiInputStandardSize">
    </div>
    </div>

    The for attribute with value inputPassword is on all fields in the search area. In the example above it should refer to body_TxtOrderNumber. If the textbox have ID="TxtOrderNumber" you could use ClientIDMode="static" or in for attribute write to ensure you get the right ID.

    I also think it still is an issue that Tea Commerce 2.3.2 override the assembly Newtonsoft.Json.dll in /bin during install on e.g. Umbraco 7.1.4. and when you uninstall Tea Commerce it also removes the assembly unless you uncheck it from the uninstall. Perhaps it should be excluded from the build a just use the one in Umbraco? see more on this in this post.

    Thanks.
    /Bjarne

  • Anders Burla Johansen 2560 posts 8256 karma points
    Jul 07, 2014 @ 09:58
    Anders Burla Johansen
    0

    Hi Bjarne

    That is Umbraco that does that. We just use their controls. So they properly has that error in the internals of Umbraco :)

  • Bjarne Fyrstenborg 1239 posts 3670 karma points MVP 5x c-trib
    Jul 08, 2014 @ 01:42
    Bjarne Fyrstenborg
    0

    Hi Anders

    yeah, it seems there is an issue with how Umbraco transform the PropertyPanel, where the label always seems to have added for="inputPassword" ... at least when using loading .aspx page in Umbraco 7.

    When the page is in a view (a html page) it could be written with the use of an alias attribute:

    <umb-control-group label="Email" description="Persons email" alias="email">
        <input type="email" id="email" class="umb-editor umb-textstring" ng-model="person.email" />
    </umb-control-group>
    
    <umb-control-group label="Biography" description="Personal life details" alias="biography">
        <textarea type="text" id="biography" class="umb-editor umb-textarea" ng-model="person.biography"></textarea>
    </umb-control-group>

    Like Umbraco some places in the backoffice load .aspx pages (which I think will be rewritten in AngularJS at some point), these pages in .aspx for Tea Commerce will in future be rewritten in AngularJS?

    /Bjarne

  • Anders Burla Johansen 2560 posts 8256 karma points
    Jul 08, 2014 @ 09:03
    Anders Burla Johansen
    100

    We will make it AngularJS when the Umbraco 7 API platform for custom sections and custom UI is stable and well polished :)

    Kind regards
    Anders

Please Sign in or register to post replies

Write your reply to:

Draft