Hi Gordon,

This is an interesting one. What version of Tea Commerce are you running first of all?

I've just been looking through the code of the FormPostHandler and from what I can tell, it should skip capturing ThreadAbortExceptions so I'm wondering why it's capturing it here.

When triggered by the HTML API like you have here, Tea Commerce will perform the adding of the code and then trigger a redirect to referer URL (or a return URL if one is provided) using Response.Redirect(url, true) where the true arg ends the current request.

I'm wondering if you have some other code some place else, maybe in an event handler or such that is trying to run, but because the FormPostHandler has already triggered the redirect, it's causing the Exception to buble up? Or could it be that the form gets submitted multiple times by mistake?

Hmm, from what I can tell, the code that ignores ThreadAbortExceptions appears to have been added in 3.0.7 going by the repository tags so if you are using 3.1.0 then I would have thought you'd have it.

It is stange though why it's reporting a ThreadAbortException when it's meant to ignore them. Could your live environment be on a different Tea Commerce version for some reason?

When you say only one works, is there one code that consistantly won't work at all? Or is it intermitant?

And can I assume the code in the error above 1J3HWZMDHE is an example of one that just won't work?

Dumb question, but you've got to cover all bases, there isn't a matching discount code defined in the system is there? It should be highly unlikely, but hey, you gotta check these things :)

The example gift card code is not real - but the correct format / length.

What do you mean by "there isn't a matching discount code defined in the system is there?" - I am using the TeaCommerce API to generate the Gift Cards and there doesn't seem (?) to be a problem generating them - the problem seems to be applying some of them to an order.

I mean in Tea Commerce you can have Discount code and Gift Cards which the form above uses the same code input field to apply both. If there happened to be a discount code with the same code then it may conflict.

As I say, it's highly unlikely, but worth checking.

Good good.

Just on the version number checking, can you look at the windows properties for the TeaCommerce.Api.Web.dll and let me know on the details tab what the "Product version" is. That's the dll that logs the error so just want to double check it's specific version.

Hey Gordon,

Looking at the changelog there is only 1 breaking change between 3.1.0 and 3.1.4 and that is 3.1.3 where there is a change in the logging service that affects Payment Providers so as long as those are updated too and any custom ones you might have are updated, it should be pretty straight forward upgrade.

https://docs.teacommerce.net/changelog/3.x/#version-3-1-3

If moving all the way up to 3.2.5 the only other release with breaking changes is 3.2.0

https://docs.teacommerce.net/changelog/3.x/#version-3-2-0

Best bet would be to review the changes and make sure none of them affect you, then just make sure you do a backup before upgrading so you can rollback if you do have a problem. Otherwise though, it should be a case of re-installing over the top.

Hope that helps

Matt

I updated to TeaCommerce 3.1.1 and ensured that the DLL's had updated (now have TeaCommerce.Api.Web.dll v3.0.7).

I found that adding 1 product to the basket and then deleting it gave this error:

 2019-01-03 10:24:51,584 [P3708/D9/T148] ERROR TeaCommerce.Umbraco.Configuration.Infrastructure.Logging.LoggingProvider - Tea Commerce FormPost error
 --- Form data:
 -- RemoveOrderLine = "orderLineId : orderLineId"
 -- storeId = "1"
 -- orderLineId = "70356"
 - Exception: System.Threading.ThreadAbortException: Thread was being aborted.
   at System.Threading.Thread.AbortInternal()
   at System.Threading.Thread.Abort(Object stateInfo)
   at System.Web.HttpResponse.AbortCurrentThread()
   at System.Web.HttpResponse.Redirect(String url, Boolean endResponse, Boolean permanent)
   at TeaCommerce.Api.Web.FormPostHandler.FormPost()
System.Threading.ThreadAbortException: Thread was being aborted.
   at System.Threading.Thread.AbortInternal()
   at System.Threading.Thread.Abort(Object stateInfo)
   at System.Web.HttpResponse.AbortCurrentThread()
   at System.Web.HttpResponse.Redirect(String url, Boolean endResponse, Boolean permanent)
   at TeaCommerce.Api.Web.FormPostHandler.FormPost()

The code used is

<form action="/base/TC/FormPost.aspx" method="post">
    <input name="RemoveOrderLine" type="hidden" value="orderLineId : orderLineId" />
    <input name="storeId" type="hidden" value="@storeId" />
    <input name="orderLineId" type="hidden" value="@orderLine.Id" />
    <button type="submit" class="button input_inline sml"><i class="fa fa-times" aria-hidden="true"></i></button>
</form>

The same error happens on our Staging site, with v3.0.6 of TeaCommerce.Api.Web.dll.

I commented out code we had for "OrderLinesAdding" and "OrderLinesRemoved" to ensure it wasn't causing the problem.

TeaCommerce seems to be aborting for unknown reasons which is causing the various problems we are having at the moment. Any ideas?

Man, I don't understand why it's logging that error. There is explicit code to skip ThreadAbortException's so it just shouldn't be getting logged.

Beyond that error, does the cart flow actually work? I found this post

https://our.umbraco.com/packages/website-utilities/tea-commerce/tea-commerce-support/77591-500-error-when-checking-out-using-paypal

that had a similar issue (toward the end) which suggests the error is largely cosmetic. Annoyingly, it says it was fixed in the version after 3.1.0 (which would be 3.1.1 https://docs.teacommerce.net/changelog/3.x/#version-3-1-1) which is what you should be on. Ultimately that fix though just skips errors that are ThreadAbortException's so really that should mean things should still be working even if you are seeing the error.

Going back to the original problem - randomly (?) non-working Gift Card codes - This is the HTML for the "add code" bit:

<form method="post" action="/base/TC/FormPost.aspx" class="form-inline form-autoValidate">
    <input name="AddDiscountCode" value="code" type="hidden" />
    <input name="AddGiftCard" value="code" type="hidden" />
    <input name="storeId" value="@storeId" type="hidden" />
    <div class="form-group">
        <input name="code" value="" type="text" placeholder="@Umbraco.Field("#Shop.EnterDiscountCode")" class="form-control input_inline width-medium" required="" />
        <input value="@Umbraco.Field("#Shop.AddDiscountCode")" class="button sml" type="submit" />
    </div>
</form>

What happens during the "AddDiscountCode" function? I've been trying to identify any differences in the data stored in the database for a working and non-working code, but haven't spotted anything yet :-(

Hey Gordon,

Regarding the blank line item, I think we'll have to address that as a separate issue / post. Best to keep this one focused on the issue at hand.

Regarding adding the gift card, ultimately adding a Gift Card calls this code (in TeaCommerce core so not publicly available)

public static AppliedGiftCard AddGiftCard( long storeId, string code ) {
  EnsureThatCurrentOrderIsntChangedAfterItsLockedForPayment( storeId );

  Order order = GetCurrentOrder( storeId );
  AppliedGiftCard appliedGiftCard = order.GiftCards.Get( code );

  if ( appliedGiftCard == null ) {
    GiftCard giftCard = GiftCardService.Instance.GetValid( storeId, code, order.CurrencyId );
    if ( giftCard != null ) {
      appliedGiftCard = new AppliedGiftCard( giftCard.Code );
      order.GiftCards.Add( appliedGiftCard );
      order.Save();
    }
  }

  return appliedGiftCard;
}

Ultimately then, it tries to see if the gift card is already added, and if not, it looks up the code and then applies it to the order.

Looking further, this calls the following repository (SQL) code:

public GiftCard GetValid( long storeId, string code, long currencyId ) {
  return GetInternal( "WHERE StoreId=@0 AND Code=@1 AND CurrencyId=@2 AND RemainingAmount > 0 AND @3 < DateValidTo", storeId, code, currencyId, DateTime.Now ).SingleOrDefault();
}

A few things worth checking then might be

1. Is your gift card assigned to the relevant store / currency of the current order?

2. What happens if you call the following code manually with a gift card code that won't apply?

   GiftCardService.Instance.GetValid( storeId, code, order.CurrencyId );
   

3. Check the RemainingAmount and also your date settings for the given Gift Card code.

Hope this helps narrow down what's going on.

Matt

Hi Gordon,

Man, I'm really struggling to think of anything else beyond asking for a full copy of your site so I can debug into it.

Were you unable to replicate this locally? If you take a full live site backup and run that locally, do those codes still not work?

Matt

Yea, do, it'll be really interesting to know if it works locally as if it does that might then suggest it's something at the server end (Could be date related, but not sure how given the working and non-working code share the same dates).

Anywho. Sorry this is taking so long to work out.

Where is the LIVE site and DB being hosted? Is it Azure?

You may need to "whitelist" your local IP, to enable a direct connection to it.

I think there's also a possible issue with "allowing multiple connections" to the DB, which can randomly play havoc with TC.

is working on a reply...