Copied to clipboard

Flag this post as spam?

This post will be reported to the moderators as potential spam to be looked at


  • MB 273 posts 936 karma points
    Jan 30, 2019 @ 18:35
    MB
    0

    Variants in backend

    Hi guys,

    I'm using Umbraco 7.11.1 with Tea Commerce 3.2.4

    I'm trying to display informations from my Document Type: Variant, but I can't seem to make them appear.

    Here's a demonstration: https://www.youtube.com/watch?v=5k5ojOpJ1c4

    // Mike

  • Matt Brailsford 4123 posts 22194 karma points MVP 9x c-trib
    Jan 30, 2019 @ 19:16
    Matt Brailsford
    1

    Hi Mike,

    I think you are missing the configuration of the variants property editor. In it's data type config you set which properties it should display.

    enter image description here

    Hope this helps

    Matt

  • MB 273 posts 936 karma points
    Jan 30, 2019 @ 19:22
    MB
    0

    Hi Matt, Thank you for helping out!

    I did a quick test and I think it should work as it is. My product price alias is "price" instead of "priceJMD".

    enter image description here enter image description here

    Do they have to be entitled "priceJMD"?

    // Mike

  • Matt Brailsford 4123 posts 22194 karma points MVP 9x c-trib
    Jan 30, 2019 @ 19:33
    Matt Brailsford
    1

    Hmmm, then I think that should work. The alias doesn't have to be "priceJMD" they just have to match.

    I'll have to look through the the code to see what the prop editor does and see if I can find out what is going on.

  • MB 273 posts 936 karma points
    Jan 30, 2019 @ 19:43
    MB
    0

    Hi Matt, I can give you access to the site if that helps in any way.

  • Matt Brailsford 4123 posts 22194 karma points MVP 9x c-trib
    Jan 30, 2019 @ 19:49
    Matt Brailsford
    1

    Sure, fire an email over to [email protected] and I'll have a look when I can.

  • MB 273 posts 936 karma points
    Jan 30, 2019 @ 19:56
    MB
    0

    Thank you Matt! I have sent an email.

    For anyone else who might face similar issue, when a solution is found I'll share it here.

    // Mike

  • Matt Brailsford 4123 posts 22194 karma points MVP 9x c-trib
    Jan 31, 2019 @ 09:59
    Matt Brailsford
    100

    Hi Mike,

    Ok, I think I've found the issue. In the Variants property editor here:

    https://github.com/TeaCommerce/Tea-Commerce-for-Umbraco/blob/master/Source/TeaCommerce.Umbraco.Application/PropertyEditors/variant-editor.controller.js#L755

    When we fetch the doctype to fetch the extra properties, we remove the last tab. This was because previously Umbraco core had generic properties on the last tab, however this was recently changed such that that generic properties are now hard coded and so don't come in the tabs collection. This now means however that removing the last tab, now removes a tab with properties on, which we don't want.

    A temp fix for you then would be to go into App_Plugins\TeaCommerce\PropertyEditors\variant-editor.controller.js, look for data.tabs.pop(); and remove that line. I think this should fix it for you for the time being and I'll get an update out as soon as I can.

    Matt

  • MB 273 posts 936 karma points
    Feb 05, 2019 @ 16:18
    MB
    0

    Hi Matt,

    I apologize for the delay in response. Apparently I'm on the influenza-monsters hit-list..

    Anyways! I really appreciate you diggin' into this issue and even being successful at finding a potential bug.

    However removing $scope.doctype = data.tabs.pop(); from variant-editor-controller.js didn't do much for me. I tried rebuilding the entire solution in Visual Studio and republishing the Umbraco site.

    Perhaps I need to do something else? Could it be a cache of some sort?

    // Mike

  • Matt Brailsford 4123 posts 22194 karma points MVP 9x c-trib
    Feb 05, 2019 @ 20:18
    Matt Brailsford
    1

    No problem.

    I'm betting cache. Make sure you clear your browser cache, and maybe increase your client dependency version number in config\ClientDependency.config, and touch your web.config.

    Hopefully that sorts it out.

    Matt

  • MB 273 posts 936 karma points
    Feb 06, 2019 @ 08:44
    MB
    0

    You're a beast Matt! Works like a C.H.A.R.M!

    Thanks for help!

    // Mike

  • Matt Brailsford 4123 posts 22194 karma points MVP 9x c-trib
    Feb 07, 2019 @ 10:33
    Matt Brailsford
    0

    Just to let you know, the official fix for this will be in the 3.3.0 release going out today.

Please Sign in or register to post replies

Write your reply to:

Draft