When we fetch the doctype to fetch the extra properties, we remove the last tab. This was because previously Umbraco core had generic properties on the last tab, however this was recently changed such that that generic properties are now hard coded and so don't come in the tabs collection. This now means however that removing the last tab, now removes a tab with properties on, which we don't want.
A temp fix for you then would be to go into App_Plugins\TeaCommerce\PropertyEditors\variant-editor.controller.js, look for data.tabs.pop(); and remove that line. I think this should fix it for you for the time being and I'll get an update out as soon as I can.
I apologize for the delay in response. Apparently I'm on the influenza-monsters hit-list..
Anyways! I really appreciate you diggin' into this issue and even being successful at finding a potential bug.
However removing $scope.doctype = data.tabs.pop(); from variant-editor-controller.js didn't do much for me. I tried rebuilding the entire solution in Visual Studio and republishing the Umbraco site.
Perhaps I need to do something else? Could it be a cache of some sort?
I'm betting cache. Make sure you clear your browser cache, and maybe increase your client dependency version number in config\ClientDependency.config, and touch your web.config.
Variants in backend
Hi guys,
I'm using Umbraco 7.11.1 with Tea Commerce 3.2.4
I'm trying to display informations from my Document Type: Variant, but I can't seem to make them appear.
Here's a demonstration: https://www.youtube.com/watch?v=5k5ojOpJ1c4
// Mike
Hi Mike,
I think you are missing the configuration of the variants property editor. In it's data type config you set which properties it should display.
Hope this helps
Matt
Hi Matt, Thank you for helping out!
I did a quick test and I think it should work as it is. My product price alias is "price" instead of "priceJMD".
Do they have to be entitled "priceJMD"?
// Mike
Hmmm, then I think that should work. The alias doesn't have to be "priceJMD" they just have to match.
I'll have to look through the the code to see what the prop editor does and see if I can find out what is going on.
Hi Matt, I can give you access to the site if that helps in any way.
Sure, fire an email over to [email protected] and I'll have a look when I can.
Thank you Matt! I have sent an email.
For anyone else who might face similar issue, when a solution is found I'll share it here.
// Mike
Hi Mike,
Ok, I think I've found the issue. In the Variants property editor here:
https://github.com/TeaCommerce/Tea-Commerce-for-Umbraco/blob/master/Source/TeaCommerce.Umbraco.Application/PropertyEditors/variant-editor.controller.js#L755
When we fetch the doctype to fetch the extra properties, we remove the last tab. This was because previously Umbraco core had generic properties on the last tab, however this was recently changed such that that generic properties are now hard coded and so don't come in the tabs collection. This now means however that removing the last tab, now removes a tab with properties on, which we don't want.
A temp fix for you then would be to go into
App_Plugins\TeaCommerce\PropertyEditors\variant-editor.controller.js, look fordata.tabs.pop();and remove that line. I think this should fix it for you for the time being and I'll get an update out as soon as I can.Matt
Hi Matt,
I apologize for the delay in response. Apparently I'm on the influenza-monsters hit-list..
Anyways! I really appreciate you diggin' into this issue and even being successful at finding a potential bug.
However removing
$scope.doctype = data.tabs.pop();from variant-editor-controller.js didn't do much for me. I tried rebuilding the entire solution in Visual Studio and republishing the Umbraco site.Perhaps I need to do something else? Could it be a cache of some sort?
// Mike
No problem.
I'm betting cache. Make sure you clear your browser cache, and maybe increase your client dependency version number in
config\ClientDependency.config, and touch your web.config.Hopefully that sorts it out.
Matt
You're a beast Matt! Works like a C.H.A.R.M!
Thanks for help!
// Mike
Just to let you know, the official fix for this will be in the 3.3.0 release going out today.
is working on a reply...