Sorry to hassle Richard - is this something you might be able to look at soon?

Hi Richard,

Any update on how the next release is coming on?

Sorry to hassle!

Thanks,

Mike

How did you configure it on that site?

Hey

... It's weird, but it seams to work now...

All the nodes have a the same compasition with a seo tab.

This is on the doctype for the frontpage where it don't work.

Local: here it works...

hmm now it's wrong again...

If you look at the title at https://www.naestved.dk/ the title and description comes from the 404 page... ?

Hey Richard

In my head partial I have:

var seoData = Umbraco.AssignedContentItem.Value<SEOChecker.MVC.MetaData>("seoChecker");

and then

<meta property="og:title" content="@(seoData.Title)" />
<meta property="og:description" content="@(seoData.Description)" />

That looks okay and works for me is it always generating the 404 page?

Hey

yes. Looks like it's always the 404, that the text are coming from.. But it's only on the root node.. All the other nodes are fine..

Sorry for the late response..

It's really wierd..

On my frontpage - the only template where the meta title/ description are wrong.. sometimes.

If you see here on https://baseline.cabana.local/ it's gives me https://baseline.cabana.local/side-for-abonneter for url and Seotitle and description for that page.

But if I publish the frontpage again it gives me the correct data...

But after som times when I publish it again I takes data from a diffrent node..

My assumption is that AssignedContentItem is not correct all the time

What happens when you use

@{
 var seo = Model.Value("seoChecker") as SEOChecker.MVC.MetaData;
   }

 @seo.AllTags

I will try. I have tried with

       Model.Value<SEOChecker.MVC.MetaData>("seoChecker");

And that did the same..

The problem is that it's not always. When I publish the frontpage it works for some time and the it fallback to a randow page again..

Hi Richard,

For us, it's not the 404 page metadata that shows, it seems to be the first page that's loaded after a recycle. It does sound like the issue is related to the property value converter as the issue doesn't occur when we avoid the property value converter.

The issue is described in more detail in my comment here: https://our.umbraco.com/packages/website-utilities/seo-checker/bugs/100772-seo-checker-title#comment-317986

Kind regards,

Mike

I think I will remove the Property value converter in that case. SEOChecker needs context of the page.

I see, yes that makes sense.

Will we still be able to make use of some kind of caching to avoid hitting the database? When we resorted to doing this:

var metadata = new MetaData(new SEOChecker.Library.MetaData(Model.Id, Culture));

we found that there were about 12 SQL queries when loading the page.

That is used for Internal use

If you use this, it is using the Umbraco published document

@{
var seo = Model.Value("your seo property here") as    SEOChecker.MVC.MetaData;
   }

@seo.AllTags

Even using this approach:

var seo = Model.Value("your seo property here") as    SEOChecker.MVC.MetaData;

@seo.AllTags

We're still seeing a caching issue. For some pages the metadata is fine. But for other pages, they show metadata for a previously visited page.

Kind regards,

Mike

Hi Michael,

I think I found the issue. https://github.com/umbraco/Umbraco-CMS/issues/8347 Will see what I can do to have a working solution in SEOChecker as well since you ideally want to have a property editor converter.

Best,

Richard

I'm running into issues with this even after updating to version 2.10.1. I have an umbraco node that functions as a template for virtual pages generated from data in an external database, using a custom icontentfinder to connect the two. See below for simplified version of what my content finder is doing.

public class ExampleFinder : IContentFinder
{

    public bool TryFindContent(PublishedRequest request)
    {
        var homeContentType = request.UmbracoContext.Content.GetContentType("home");
        var homeNode = request.UmbracoContext.Content.GetByContentType(homeContentType).FirstOrDefault();
        var virtualTemplate = home.VirtualTemplate; // Virtual Template is a content picker pointing at the virtual page template 
        virtualTemplate.VirtualData = new {...}; //adds external data to page
        request.PublishedContent = virtualTemplate;
        return true;
    }
}

Unfortunately, after the data is run through the value converter, it uses the default title set for the doc type instead of the title set on the node.

I'm guessing this is because the request url is a factor in the value converter, as the url on the front end won't match the actual url of the node. I tried using a few methods to get the correct value

Model.Value("seoChecker") as SEOChecker.Library.MetaData

Model.Value<SEOChecker.Library.MetaData>("seoChecker

new SEOChecker.MVC.MetaData(Model.Id)

to see if that gave the correct value, but none did. Any recommendations to resolve this? I can work around it for now with

Model.GetProperty("seoChecker").GetSourceValue()

which gives the correct values for the node, but would prefer to avoid having to manually overwrite the data with the correct values.

Hi Jesse,

This is related to the virtual node. Then it will use the node Id of the virtual nod instead of the actual node. If you can map to the actual Umbraco node and get the property from there it should work, otherwise it will always use the virtual node.

Best,

It's supposed to be using the virtual node id, as data for these pages aren't stored in umbraco nodes. The actual data is injected into the meta data after retrieving it from the "seoChecker" property. My issue is that it's using the fallback title even though a title is set on the node I'm using as a template. See the screenshots below for how I have it configured at the moment.

My expectation is that meta data title would be "{#@categories}," but for some reason it's "{#@virtualName}" instead (both of these are keywords I use to inject information from the passed in virtual data). I know the correct node is referenced, as

Model.GetProperty("seoChecker").GetSourceValue()

does have "{#@categories}" as the seoTitle, but this value isn't pulled in when I call

Model.Value<SEOChecker.Library.MetaData>("seoChecker")

and instead uses the default "{#@virtualName}."

I am able to work around this issue by injecting the source value data into the meta data string, so this isn't an urgent issue for me. Would just allow me to keep my code a little cleaner.

Lastly, I forgot to mention in my earlier post. I'm running this on Umbraco 8.6.4 in case that affects anything.